crypto: fix inclusion of OPENSSL_IS_BORINGSSL define

[codebytere]

Refs #58387.

Fixes OPENSSL_IS_BORINGSSL not being defined in cases where it should be due to missing include. See relevant BoringSSL file

[nodejs-github-bot]

Review requested:

• @nodejs/config

[codebytere]

@jasnell looks like openssl itself doesn't have base.h - looks like to ensure it works I just need to include a file that normal OpenSSL does export, bc in BoringSSL they all include base.h. Do you have a preference?

See ex:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (b4c5fb4) to head (a0c73cd).
Report is 33 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58845 +/- ## ========================================== + Coverage 90.08% 90.10% +0.02%  ========================================== Files 640 640 Lines 188446 188426 -20 Branches 36960 36953 -7 ========================================== + Hits 169757 169786 +29 + Misses 11412 11350 -62 - Partials 7277 7290 +13 

Files with missing lines	Coverage Δ
src/node_config.cc	96.55% <ø> (ø)

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jasnell]

No particular preference @codebytere ... I'd trust whatever you think needs to be done and whatever makes it work for you

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67745/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67753/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/58845 ✔ Done loading data for nodejs/node/pull/58845 ----------------------------------- PR info ------------------------------------ Title crypto: fix inclusion of `OPENSSL_IS_BORINGSSL` define (#58845) Author Shelley Vohr <[email protected]> (@codebytere) Branch codebytere:fix-have-crypto -> nodejs:main Labels c++ Commits 2 - crypto: fix inclusion of OPENSSL_IS_BORINGSSL define - Update src/node_config.cc Committers 1 - Shelley Vohr <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58845 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58845 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 26 Jun 2025 12:59:57 GMT ✔ Approvals: 5 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58845#pullrequestreview-2970781596 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58845#pullrequestreview-2962886452 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/58845#pullrequestreview-2967069855 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58845#pullrequestreview-2967665439 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58845#pullrequestreview-2972085344 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-30T18:46:52Z: https://ci.nodejs.org/job/node-test-pull-request/67753/ - Querying data for job/node-test-pull-request/67753/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 58845 From https://github.com/nodejs/node * branch refs/pull/58845/merge -> FETCH_HEAD ✔ Fetched commits as 2022f832a98b..a0c73cda8176 -------------------------------------------------------------------------------- [main 77a12159c6] crypto: fix inclusion of OPENSSL_IS_BORINGSSL define Author: Shelley Vohr <[email protected]> Date: Thu Jun 26 14:57:05 2025 +0200 1 file changed, 4 insertions(+) [main baccb14ceb] Update src/node_config.cc Author: Shelley Vohr <[email protected]> Date: Mon Jun 30 10:16:10 2025 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- crypto: fix inclusion of OPENSSL_IS_BORINGSSL define 
PR-URL: #58845
 Reviewed-By: James M Snell <[email protected]>
 Reviewed-By: Juan José Arboleda <[email protected]>
 Reviewed-By: Anna Henningsen <[email protected]>
 Reviewed-By: Luigi Pinca <[email protected]>
 Reviewed-By: Ethan Arrowood <[email protected]>
[detached HEAD 9574c03bfe] crypto: fix inclusion of OPENSSL_IS_BORINGSSL define
 Author: Shelley Vohr <[email protected]>
 Date: Thu Jun 26 14:57:05 2025 +0200
 1 file changed, 4 insertions(+)
 Rebasing (3/4)
 Rebasing (4/4)
 Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Update src/node_config.cc
Co-authored-by: Anna Henningsen <[email protected]>
 PR-URL: #58845
 Reviewed-By: James M Snell <[email protected]>
 Reviewed-By: Juan José Arboleda <[email protected]>
 Reviewed-By: Anna Henningsen <[email protected]>
 Reviewed-By: Luigi Pinca <[email protected]>
 Reviewed-By: Ethan Arrowood <[email protected]>
[detached HEAD 243b9df2f2] Update src/node_config.cc
 Author: Shelley Vohr <[email protected]>
 Date: Mon Jun 30 10:16:10 2025 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
 Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/15993773799

[nodejs-github-bot]

Landed in a7a37c3