build: use //third_party/simdutf by default in GN#58115
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
zcbenz approved these changes May 2, 2025
anonrig approved these changes May 2, 2025
anonrig added author ready 
legendecas approved these changes May 2, 2025
nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit 5aad0a7 into nodejs:main 26 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented May 4, 2025
Landed in 5aad0a7 |
aduh95 pushed a commit that referenced this pull request May 8, 2025
PR-URL: #58115 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
PR-URL: #58115 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jun 26, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 26, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 28, 2025
* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025
codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025
codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025
* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
//third_party/simdutfby default in the GN build instead ofdeps/simdutf. Similar to what's currently done for//third_party/zlibfor the same reason.Added in https://chromium-review.googlesource.com/c/v8/node-ci/+/6177642