2025-05-08, Version 24.0.1 (Current)#58226
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 0579e0e PR-URL: #58211 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #57825 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #58093 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps the eslint group in /tools/eslint with 6 updates: | Package | From | To | | --- | --- | --- | | [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.26.10` | `7.27.1` | | [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) | `7.27.0` | `7.27.1` | | [@babel/plugin-syntax-import-attributes](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-syntax-import-attributes) | `7.26.0` | `7.27.1` | | [@babel/plugin-syntax-import-source](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-syntax-import-source) | `7.25.9` | `7.27.1` | | [eslint](https://github.com/eslint/eslint) | `9.23.0` | `9.25.1` | | [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | `50.6.9` | `50.6.11` | Updates `@babel/core` from 7.26.10 to 7.27.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.27.1/packages/babel-core) Updates `@babel/eslint-parser` from 7.27.0 to 7.27.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.27.1/eslint/babel-eslint-parser) Updates `@babel/plugin-syntax-import-attributes` from 7.26.0 to 7.27.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.27.1/packages/babel-plugin-syntax-import-attributes) Updates `@babel/plugin-syntax-import-source` from 7.25.9 to 7.27.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.27.1/packages/babel-plugin-syntax-import-source) Updates `eslint` from 9.23.0 to 9.25.1 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.23.0...v9.25.1) Updates `eslint-plugin-jsdoc` from 50.6.9 to 50.6.11 - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v50.6.9...v50.6.11) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 7.27.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint - dependency-name: "@babel/eslint-parser" dependency-version: 7.27.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@babel/plugin-syntax-import-attributes" dependency-version: 7.27.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint - dependency-name: "@babel/plugin-syntax-import-source" dependency-version: 7.27.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint dependency-version: 9.25.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint-plugin-jsdoc dependency-version: 50.6.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #58105 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.5.0 to 5.6.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@8d9ed9a...a26af69) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 5.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #58107 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@cdca736...49933ea) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #58111 Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
From the source code, `readlinePromises.createInterface()` calls `new Interface()` imported from `internal/readline/interface`, which works the same as the non-promise version. If non-promise version accepts options.signal, it should also work for `readlinePromises.createInterface()`. Hence this information need to be indicated in the documentation. Refs: https://github.com/nodejs/node/blob/main/lib/readline/promises.js PR-URL: #55456 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58115 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #58128 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Edy Silva <[email protected]>
PR-URL: #58129 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
This will remove three of the four "A parse error occurred" issues during JavaScript CodeQL scans. (The fourth occurrence is in our code base, although it might be a false positive. Someone can figure that one out sooner or later, but we certainly can bypass scanning V8 tools.) PR-URL: #58132 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Current alignment mislead doc reader into thinking `importModuleDynamically` is a separate positional param right next to `options`, which is incorrect and need to be fixed. This misalignment is introduced in a PR merged in Feb 2024. I belive this doc fix applies to node v20 and above. Refs: #51244 PR-URL: #58145 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
PR-URL: #57600 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #58175 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #57980 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Xuguang Mei <[email protected]>
github-actionsbot added release 
Collaborator
nodejs-github-bot commented May 8, 2025
Review requested:
|
Contributor
This comment was marked as outdated.
This comment was marked as outdated.
targos approved these changes May 8, 2025
Collaborator
nodejs-github-bot commented May 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## v24.x #58226 +/- ## ========================================== - Coverage 90.18% 90.13% -0.05% ========================================== Files 630 630 Lines 186524 186650 +126 Branches 36626 36638 +12 ========================================== + Hits 168217 168245 +28 - Misses 11127 11199 +72 - Partials 7180 7206 +26
🚀 New features to boost your workflow:
|
aduh95 merged commit f7b92d7 into v24.x 72 of 73 checks passed
Uh oh!
There was an error while loading. Please reload this page.
aduh95 added a commit to aduh95/nodejs.org that referenced this pull request May 8, 2025
5 tasks
github-merge-queuebot pushed a commit to nodejs/nodejs.org that referenced this pull request May 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2025-05-08, Version 24.0.1 (Current), @aduh95
Notable Changes
2e1d9581e0] - Revert "buffer: move SlowBuffer to EOL" (Filip Skokan) #58211Commits
d38e811c5b] - benchmark: fix typo in method name for error-stack (Miguel Marcondes Filho) #581282e1d9581e0] - Revert "buffer: move SlowBuffer to EOL" (Filip Skokan) #58211a883b0c979] - build: use //third_party/simdutf by default in GN (Shelley Vohr) #581153d84b5c7a4] - doc: add HBSPS as triager (Wiyeong Seo) #579801e57cb686e] - doc: add history entries to--input-typesection (Antoine du Hamel) #581750b54f06b6f] - doc: add ambassaor message (Brian Muenzenmeyer) #5760046bee52d57] - doc: fix misaligned options in vm.compileFunction() (Jimmy Leung) #58145e732a8bfdd] - doc: fix typo in benchmark script path (Miguel Marcondes Filho) #58129d49ff34adb] - doc: add missing options.signal to readlinePromises.createInterface() (Jimmy Leung) #55456bc9f5a2e79] - doc: fix typo of filezlib.md(yusheng chen) #58093c8e8558958] - doc: clarify future Corepack removal in v25+ (Trivikram Kamat) #57825b13d5d14bd] - meta: bump actions/setup-node from 4.3.0 to 4.4.0 (dependabot[bot]) #581110ebb17a300] - meta: bump actions/setup-python from 5.5.0 to 5.6.0 (dependabot[bot]) #581075946785bf4] - tools: exclude deps/v8/tools from CodeQL scans (Rich Trott) #581320708497c7f] - tools: bump the eslint group in /tools/eslint with 6 updates (dependabot[bot]) #58105