punycode: update to v1.3.2#6
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
rvagg commented Nov 28, 2014
Sweet! LGTM. Can we have a high-level summary of what this gets us? I see some regex tweaks and domain changes in there. |
ContributorAuthor
mathiasbynens commented Nov 28, 2014
|
Member
indutny commented Nov 28, 2014
@mathiasbynens could this be put in a commit message? ;) |
Changes since v1.2.3: * Email address support in `toASCII` and `toUnicode` * `punycode.ucs2.encode` now no longer mutates the `codePoints` argument * Ensure trailing `.` in domain names are preserved * Some minor code cleanup + bug fixes
ContributorAuthor
mathiasbynens commented Nov 28, 2014
@indutny Done. I gotta say, I’m impressed by the swift responses! 👍 |
Member
indutny commented Nov 28, 2014
This is just a coincidence, don't get used to it ;) Anyway, thank you very much! |
indutny pushed a commit that referenced this pull request Nov 28, 2014
Changes since v1.2.3: * Email address support in `toASCII` and `toUnicode` * `punycode.ucs2.encode` now no longer mutates the `codePoints` argument * Ensure trailing `.` in domain names are preserved * Some minor code cleanup + bug fixes Reviewed-By: Fedor Indutny <[email protected]> PR-URL: #6
Member
indutny commented Nov 28, 2014
Landed in 232c4c2, thank you! |
Closed
minervapanda pushed a commit to minervapanda/node that referenced this pull request Oct 9, 2016
thlorenz referenced this pull request in thlorenz/node Nov 21, 2016
jasongin pushed a commit to jasongin/nodejs that referenced this pull request Dec 8, 2016
Closed
5 tasks
targos referenced this pull request in targos/node Apr 17, 2021
Original commit message: Merged: [wasm-simd][x64] Check for register when emitting shuffles Some shuffles take have either register or memory operand for second input, but the codegen incorrectly assumes that it is always a register. Bug: v8:10824 (cherry picked from commit ddf30bea13902829eeb71aa0ec747155e27e5a68) Change-Id: I897c4290a8b91ff2ab839e98b16a9696c0bae511 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391280 Reviewed-by: Bill Budge <[email protected]> Commit-Queue: Zhi An Ng <[email protected]> Cr-Commit-Position: refs/branch-heads/8.6@{#6} Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472} Refs: v8/v8@516b5d3
targos referenced this pull request in targos/node Apr 27, 2021
Original commit message: Merged: [wasm-simd][x64] Check for register when emitting shuffles Some shuffles take have either register or memory operand for second input, but the codegen incorrectly assumes that it is always a register. Bug: v8:10824 (cherry picked from commit ddf30bea13902829eeb71aa0ec747155e27e5a68) Change-Id: I897c4290a8b91ff2ab839e98b16a9696c0bae511 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391280 Reviewed-by: Bill Budge <[email protected]> Commit-Queue: Zhi An Ng <[email protected]> Cr-Commit-Position: refs/branch-heads/8.6@{#6} Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472} Refs: v8/v8@516b5d3
targos added a commit that referenced this pull request Apr 30, 2021
Original commit message: Merged: [wasm-simd][x64] Check for register when emitting shuffles Some shuffles take have either register or memory operand for second input, but the codegen incorrectly assumes that it is always a register. Bug: v8:10824 (cherry picked from commit ddf30bea13902829eeb71aa0ec747155e27e5a68) Change-Id: I897c4290a8b91ff2ab839e98b16a9696c0bae511 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391280 Reviewed-by: Bill Budge <[email protected]> Commit-Queue: Zhi An Ng <[email protected]> Cr-Commit-Position: refs/branch-heads/8.6@{#6} Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472} Refs: v8/v8@516b5d3 PR-URL: #38275 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.