test: move debugger tests to sequential#6205
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. Fixes: nodejs#6201
MemberAuthor
Trott commented Apr 14, 2016
I suspect the issue is that the tests are relying on the default debug port and so they are colliding when run in parallel. But that's just a guess for the moment. Since they are the only debugger tests in parallel, it wasn't until the second test was introduced that the issue became apparent. /cc @nodejs/testing |
Trott changed the title MemberAuthor
Trott commented Apr 14, 2016
MemberAuthor
Trott commented Apr 14, 2016
CI is totally green. Can I get an I think expediting this is justified. While CI isn't affected, having |
Contributor
Fishrock123 commented Apr 15, 2016
@Trott Also see the error on master. This fixes it for me. LGTM! |
Member
jbergstroem commented Apr 15, 2016
LGTM |
Trott added a commit to Trott/io.js that referenced this pull request Apr 15, 2016
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: nodejs#6205Fixes: nodejs#6201 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MemberAuthor
Trott commented Apr 15, 2016
Landed in 00b2219 |
Member
santigimeno commented Apr 16, 2016
PR to move the tests back to parallel: #6246 |
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: #6205Fixes: #6201 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: #6205Fixes: #6201 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
This was referenced Apr 21, 2016
Closed
Closed
Contributor
MylesBorins commented Apr 21, 2016
@Trott lts? |
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: #6205Fixes: #6201 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MemberAuthor
Trott commented Apr 21, 2016
@thealphanerd Yes. (And then also @santigimeno's later PR that fixes them up for parallelism and moves them back!) |
Contributor
MylesBorins commented Apr 21, 2016
this should land with b95160d |
jasnell pushed a commit that referenced this pull request Apr 26, 2016
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: #6205Fixes: #6201 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
santigimeno pushed a commit to santigimeno/node that referenced this pull request May 18, 2016
The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: nodejs#6205Fixes: nodejs#6201 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test debugger
Description of change
test-debugger-util-regression fails with
make testsometimes (all thetime?). This appears to be related to running in parallel, as it does
not fail with
make test-ci, when run viatools/test.pyor directlyfrom the command line with
./node test/parallel/test-debugger-util-regression.js.A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix
make testpromptly.
Fixes: #6201