test: move the debugger tests back to parallel#6246
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Run the debugger with `--port=common.PORT` to avoid the use of the same port.
2 tasks
Contributor
MylesBorins commented Apr 16, 2016
Member
Trott commented Apr 17, 2016
LGTM. CI looks good (known flaky only failure) and |
Member
addaleax commented Apr 18, 2016
LGTM |
1 similar comment
Contributor
cjihrig commented Apr 18, 2016
LGTM |
santigimeno added a commit to santigimeno/node that referenced this pull request Apr 18, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: nodejs#6246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
santigimeno commented Apr 18, 2016
Thanks for the reviews. Landed in b95160d |
Member
addaleax commented Apr 18, 2016
👍 Btw, your |
MemberAuthor
santigimeno commented Apr 18, 2016
No it was not :(. I was wondering if I should fix it |
Member
addaleax commented Apr 18, 2016
I don’t think that matters much, I mean, the |
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: #6246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: #6246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Apr 21, 2016
Closed
Closed
Contributor
MylesBorins commented Apr 21, 2016
@nodejs/testing is this something we want in lts? |
MemberAuthor
santigimeno commented Apr 21, 2016
I would say so. It should land after #6205 |
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: #6246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
MylesBorins commented Apr 21, 2016
this should land with 00b2219 |
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: nodejs#6246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: #6246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
MylesBorins commented May 17, 2016
santigimeno added a commit to santigimeno/node that referenced this pull request May 18, 2016
Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: nodejs#6246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
santigimeno commented May 18, 2016
MemberAuthor
santigimeno commented May 18, 2016
2 tasks
Member
Trott commented May 19, 2016
I'm inclined to suggest that we label this as |
MemberAuthor
santigimeno commented May 19, 2016
Agreed. Labeling as |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Run the debugger with
--port=common.PORTto avoid the use of the sameport.
/cc @nodejs/testing