[v4.x backport] test: run v8 tests from node tree#7451

MylesBorins · 2016-06-28T00:12:14Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

tools

Description of change

This is a backport of cd720f8 from #4704 which enables running the V8 test suite on v4.x

ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/157/

(there are currently 4 failures, not sure what they are related to)

/cc @nodejs/lts @nodejs/V8 @ofrobots @mhdawson

mscdex · 2016-06-28T03:31:18Z

Are the log files necessary?

targos · 2016-06-28T06:33:25Z

The log files are necessary. They were filtered out by a rule in our .gitignore

targos · 2016-06-28T06:42:15Z

Reference for the failures: https://bugs.chromium.org/p/v8/issues/detail?id=2899

See https://codereview.chromium.org/1402373002 for a solution.

bnoordhuis · 2016-06-28T06:45:26Z

Hah, I was just about to post that v8/v8@9c927d0 should fix the test failures; the issue is with the default system locale.

bnoordhuis · 2016-06-28T06:50:08Z

LGTM BTW

targos · 2016-06-28T06:53:17Z

LGTM too

MylesBorins · 2016-06-28T08:23:23Z

I've added a backport of v8/v8@9c927d0

V8 ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/159/
ci: https://ci.nodejs.org/job/node-test-pull-request/3102/

MylesBorins · 2016-06-28T08:27:34Z

@targos @bnoordhuis PTAL

targos · 2016-06-28T08:44:04Z

deps/v8/tools/run-tests.py

the indentation is wrong

bnoordhuis · 2016-06-28T08:48:16Z

LGTM

targos · 2016-06-28T08:56:48Z

LGTM

mhdawson · 2016-06-28T15:05:32Z

From what I can see its not running quite right in the CI. The output of the jobs look a bit different. What that on purpose (the full output of the tests being run versus the dots ?)

mhdawson · 2016-06-28T15:09:26Z

Looking more closely I think the answer to my question is no, as the result is that the job shows as failed even though the tests appear to have passed. In particular the tap file with the results is not being generated:

+ cp deps/v8/v8-tap.xml v8-tap.xml cp: cannot stat 'deps/v8/v8-tap.xml': No such file or directory

jasnell · 2016-06-28T15:35:43Z

LGTM

MylesBorins · 2016-06-28T17:30:00Z

One more run in CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/161/

@mhdawson I noticed that as well re: tap output. What is strange is that the first run of this change seemed to produce the tap output (this is where the failures came up). Can you think of any reason the tap output would not be produced?

MylesBorins · 2016-06-28T18:39:46Z

I've opened #7460 which should solve the problem with the tap file. Once that has landed I'll add it to the backport

Ported by exinfinitum from a PR by jasnell: see nodejs/node-v0.x-archive#14185 Allows the running of v8 tests on node's packaged v8 source code. Note that the limited win32 support added by jasnell has NOT been ported, and so these tests are currently UNIX ONLY. Note that gclient depot tools (see https://commondatastorage.googleapis.com/ chrome-infra-docs/flat/depot_tools/docs/html/ depot_tools_tutorial.html#_setting_up) and subversion are required to run tests. To perform tests, run the following commands: make v8 DESTCPU=(ARCH) make test-v8 DESTCPU=(ARCH) where (ARCH) is your CPU architecture, e.g. x64, ia32. DESTCPU MUST be specified for this to work properly. Can also do tests on debug build by using "make test-v8 DESTCPU=(ARCH) BUILDTYPE=Debug", or perform intl or benchmark tests via make test-v8-intl or test-v8-benchmarks respectively. Note that by default, quickcheck and TAP output are disabled, and i18n is enabled. To activate these options, use options"QUICKCHECK=True" and "ENABLE_V8_TAP=True" respectively. Use "DISABLE_V8_I18N" to disable i18n. Use V8_BUILD_OPTIONS to allow custom user-defined flags to be appended onto "make v8". Any tests performed after changes to the packaged v8 file will require recompiling of v8, which can be done using "make v8 DESTCPU=(ARCH)". Finally, two additional files necessary for one of the v8 tests have been added to the v8 folder. PR-URL: nodejs#4704 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]>

MylesBorins · 2016-06-29T21:36:09Z

I've now included a backport of the fix from upstream... running CI one more time. Will land in v4.x-staging in green.

ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/167/

Original commit message: [test] Set default locale in test runner BUG=v8:4437,v8:2899,chromium:604310 LOG=n Review URL: https://codereview.chromium.org/1402373002 Cr-Commit-Position: refs/heads/master@{nodejs#35614} PR-URL: nodejs#7451 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: nodejs#7460 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

MylesBorins · 2016-06-29T23:06:35Z

landed in 48949fb...72de1ce

Original commit message: [test] Set default locale in test runner BUG=v8:4437,v8:2899,chromium:604310 LOG=n Review URL: https://codereview.chromium.org/1402373002 Cr-Commit-Position: refs/heads/master@{#35614} PR-URL: #7451 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * backport 9c927d0f01 from V8 upstream (Myles Borins) #7451 * cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Original commit message: deps: backport 9c927d0f01 from V8 upstream Original commit message: [test] Set default locale in test runner BUG=v8:4437,v8:2899,chromium:604310 LOG=n Review URL: https://codereview.chromium.org/1402373002 Cr-Commit-Position: refs/heads/master@{#35614} PR-URL: nodejs/node#7451 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

MylesBorins added v8 engine Issues and PRs related to the V8 dependency. tools Issues and PRs related to the tools directory. v4.x semver-minor PRs that contain new features and should be released in the next minor version. labels Jun 28, 2016

mscdex added the test Issues and PRs related to the tests. label Jun 28, 2016

MylesBorins force-pushed the V8-testrunner-backport branch 2 times, most recently from 8b991d8 to 5f92123Compare June 28, 2016 08:27

targos reviewed Jun 28, 2016
View reviewed changes

MylesBorins force-pushed the V8-testrunner-backport branch from 5f92123 to 6f6a2d7Compare June 28, 2016 08:46

MylesBorins changed the title ~~test: run v8 tests from node tree~~test: run v8 tests from node tree [v4.x backport]Jun 28, 2016

MylesBorins force-pushed the v4.x-staging branch from ed3d372 to f14d9cfCompare June 28, 2016 22:49

MylesBorins changed the title ~~test: run v8 tests from node tree [v4.x backport]~~[WIP] test: run v8 tests from node tree [v4.x backport]Jun 29, 2016

MylesBorins added the wip Issues and PRs that are still a work in progress. label Jun 29, 2016

MylesBorins changed the title ~~[WIP] test: run v8 tests from node tree [v4.x backport]~~[WIP][v4.x backport] test: run v8 tests from node treeJun 29, 2016

MylesBorins force-pushed the V8-testrunner-backport branch from 6f6a2d7 to 1496fecCompare June 29, 2016 21:35

MylesBorins removed the wip Issues and PRs that are still a work in progress. label Jun 29, 2016

MylesBorins changed the title ~~[WIP][v4.x backport] test: run v8 tests from node tree~~[v4.x backport] test: run v8 tests from node treeJun 29, 2016

MylesBorinsand others added 2 commits June 29, 2016 16:03

MylesBorins force-pushed the V8-testrunner-backport branch from 1496fec to 72de1ceCompare June 29, 2016 23:03

MylesBorins merged commit 72de1ce into nodejs:v4.x-stagingJun 29, 2016

MylesBorins mentioned this pull request Jun 29, 2016
Managing floating V8 patches nodejs/Release#111
Closed

MylesBorins deleted the V8-testrunner-backport branch July 8, 2016 14:51

MylesBorins mentioned this pull request Jul 12, 2016
Semver-Minor commits in v4.x-staging nodejs/Release#120
Closed

MylesBorins mentioned this pull request Jul 12, 2016
v4.5.0 proposal #7688
Merged

Uh oh!

[v4.x backport] test: run v8 tests from node tree#7451

[v4.x backport] test: run v8 tests from node tree #7451

Uh oh!

Conversation

MylesBorins commented Jun 28, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

mscdex commented Jun 28, 2016

Uh oh!

targos commented Jun 28, 2016

Uh oh!

targos commented Jun 28, 2016

Uh oh!

bnoordhuis commented Jun 28, 2016

Uh oh!

bnoordhuis commented Jun 28, 2016

Uh oh!

targos commented Jun 28, 2016

Uh oh!

MylesBorins commented Jun 28, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MylesBorins commented Jun 28, 2016

Uh oh!

targosJun 28, 2016

Choose a reason for hiding this comment

Uh oh!

MylesBorinsJun 28, 2016

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Jun 28, 2016

Uh oh!

targos commented Jun 28, 2016

Uh oh!

mhdawson commented Jun 28, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhdawson commented Jun 28, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Jun 28, 2016

Uh oh!

MylesBorins commented Jun 28, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MylesBorins commented Jun 28, 2016

Uh oh!

MylesBorins commented Jun 29, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MylesBorins commented Jun 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MylesBorins commented Jun 28, 2016•
edited
Loading

mhdawson commented Jun 28, 2016•
edited
Loading

mhdawson commented Jun 28, 2016•
edited
Loading

MylesBorins commented Jun 28, 2016•
edited
Loading

MylesBorins commented Jun 29, 2016•
edited
Loading