tools: explicit path for V8 test tap output#7460
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MylesBorins added v8 engine ContributorAuthor
modified ci job: https://ci.nodejs.org/job/thealphanerd-test-commit-v8-linux/1/ edit: modified CI is green /cc @mhdawson @nodejs/v8 |
2 tasks
ContributorAuthor
MylesBorins commented Jun 28, 2016
/cc @nodejs/build not 100% this is the way we want to solve it... PTAL |
Member
mhdawson commented Jun 28, 2016
We could make it more flexible so you can specify the path, but I think this will be good for people running the test so I'm good with what you have LGTM. |
Member
jasnell commented Jun 28, 2016
Lgtm |
Contributor
thefourtheye commented Jun 29, 2016
LGTM |
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: nodejs#7460 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorinsforce-pushed the V8-testrunner-explicit-tap-path branch from 7b75e6b to cae428aCompareContributorAuthor
MylesBorins commented Jun 29, 2016
@mhdawson I've gone ahead and updated the CI job to no longer cp the file from v8 -> root as the new default is to place the xml in the root directory. This may need to be updated in other CI jobs outside of node. |
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jun 29, 2016
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: nodejs#7460 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: #7460 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: #7460 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
Currently we do not specific an absolute path for the tap output of the
V8 test suite. This is proving to be unreliable across release lines.
By prepending
$(PWD)to each path we can guarantee it will always bein the root folder.
This change will require an update to the jenkins job