test: fix flaky test-net-write-slow#7555
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: nodejs#7516
Trott added net 
MemberAuthor
Trott commented Jul 6, 2016
(Still kind of wonder if the test shouldn't be removed, though. See #7516 for archeological and other details.) |
MemberAuthor
Trott commented Jul 6, 2016
MemberAuthor
Trott commented Jul 6, 2016
CI is green. |
MemberAuthor
Trott commented Jul 6, 2016
@nodejs/testing |
Contributor
mscdex commented Jul 6, 2016
What about changing the timeout value based on |
Merged
MemberAuthor
Trott commented Jul 6, 2016
@mscdex That's an option, but I don't think it's preferable in this situation. The arbitrarily large value doesn't make the test take any longer to pass. If it affected the test duration, I'd be inclined to tune the value based on platform. But since it doesn't affect execution time on successful tests, I'd prefer to avoid the complexity of different values on different platforms. |
4 tasks
MemberAuthor
Trott commented Jul 6, 2016
This FreeBSD failure on CI is starting to get a little out of control, so I'm going to try to raise the profile of this fix and argue for an expedited landing (small change, big positive impact, easy to revert, doesn't affect userland code). Raising profile: @nodejs/collaborators |
Member
mcollina commented Jul 6, 2016
LGTM |
3 tasks
Member
santigimeno commented Jul 7, 2016
LGTM |
Trott added a commit to Trott/io.js that referenced this pull request Jul 7, 2016
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: nodejs#7516 PR-URL: nodejs#7555 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MemberAuthor
Trott commented Jul 7, 2016
Landed in 9d654a3. Goodbye, red FreeBSD CI. |
2 tasks
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: #7516 PR-URL: #7555 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: #7516 PR-URL: #7555 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: #7516 PR-URL: #7555 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: #7516 PR-URL: #7555 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: #7516 PR-URL: #7555 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: #7516 PR-URL: #7555 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Increase socket timeout so that there is enough time to reliably run the test on FreeBSD. Fixes: #7516 PR-URL: #7555 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test net
Description of change
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.
Fixes: #7516