build: respect --shared-* flags for inspector deps#7569
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added openssl 
Contributor
MylesBorins commented Jul 7, 2016
will land tomorrow if CI is green and we have no objects /cc @nodejs/lts @nodejs/collaborators |
Member
bnoordhuis commented Jul 7, 2016
LGTM |
MemberAuthor
ChALkeR commented Jul 8, 2016
Note: this also fixes #7583. |
Contributor
ofrobots commented Jul 8, 2016
LGTM |
ChALkeRforce-pushed the inspector-shared-deps branch from 485d167 to b0eac38CompareMemberAuthor
Don't build openssl/http_parser/libuv for v8_inspector if corresponding --shared-* flags were passed to the ./configure script. Fixes: nodejs#7478Fixes: nodejs#7583 PR-URL: nodejs#7569 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
ChALkeRforce-pushed the inspector-shared-deps branch from b0eac38 to 990c968Compare
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
Don't build openssl/http_parser/libuv for v8_inspector if corresponding --shared-* flags were passed to the ./configure script. Fixes: #7478Fixes: #7583 PR-URL: #7569 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 testpassesAffected core subsystem(s)
build
Description of change
Don't build openssl/http_parser/libuv for v8_inspector if corresponding
--shared-*flags were passed to the./configurescript.Fixes: #7478
./configure --shared-openssl --without-intl --shared-http-parser; make -j4 testworks and doesn't build openssl and http-parser even with v8_inspector enabled.#7486 fixed that only for the case when
--without-inspectorwas passed.CI: https://ci.nodejs.org/job/node-test-pull-request/3194/
/cc @bnoordhuis@ofrobots