Backport 2253#8340
Backport 2253 #8340
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: nodejs#7538 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Manual backport from master to 4.x stream, original commit message follows. I often want to run a test many times to see if a failure can be recreated and I believe this is a common use case. We even have this job in the CI https://ci.nodejs.org/job/node-stress-single-test/configure but often you want to run it on a specific machine. This patch adds the --repeat option so that you can repeat the selected set of tests a number of times. Given existing options in test.py this will allow you to run one or more tests for the number of repeats specified. For example: tools/test.py -j8 --repeat 1000 parallel/test-process-exec-argv runs the test-process-exec-argv test 1000 times, running 8 copies in parallel tools/test.py --repeat 2 would run the entire test suite twice. PR-URL: nodejs#6700 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]> Reviewed-By: joaocgreis - João Reis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Enable targetting of a different node version than the currently running one when building binary modules. Based on nodejs/node@410296c37 PR-URL: nodejs#8171 Ref: nodejs#8027 Ref: nodejs#7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Minor rewording related to making a server listen to a random port, and added how to retrieve which port was randomly chosen by the OS. Also changed documented `server.listen()` signature as it does in fact not require `port` to be provided. PR-URL: nodejs#8025 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: nodejs#8076 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This test fails on Solaris, see nodejs#2253
Use `close` event rather than `exit` event to make sure all output has been received before checking assertions. Fixes: nodejs#6722
MylesBorins commented Sep 4, 2016
hey @bmeck is looks like this is failing |
bmeck commented Sep 4, 2016
As stated yes. This just adds tests On Sep 4, 2016 1:38 PM, "Myles Borins" [email protected] wrote:
|
MylesBorins commented Sep 7, 2016
@bmeck I am a bit confused then. Adding this should not break the local test suite. Am I missing something? |
@thealphanerd this only adds tests, v4 does not have correct behavior. original issue that led to these tests could never deduce the cause of the race/error. Tests were rebased onto newer branch, issue was gone. Guessing w/e fixed v6 was not backported to v4 |
MylesBorins commented Sep 8, 2016
@bmeck thanks! I'll keep this one in the background then and revisit after the next round of audits to see if it is fixed |
MylesBorinsforce-pushed the v4.x-staging branch from 5b79c90 to f98a94bCompareMylesBorinsforce-pushed the v4.x-staging branch 2 times, most recently from 6a126fb to 004d665Compare
MylesBorinsforce-pushed the v4.x-staging branch from 15ec16e to 9049c1fCompareMylesBorins commented Nov 14, 2016
I'm closing this for now |
9 participants
Checklist
Affected core subsystem(s)
tests
Description of change
add tests for the behavior of using
-rand--requireto ensure they are preloaded even when using interactive/streamed entry points