Skip to content

Conversation

@lukekarrys
Copy link
Contributor

@lukekarryslukekarrys commented Mar 22, 2022

Requires: npm/npm-registry-fetch#107

This also allows logs-max to be set to 0 to disable log file writing.

Closes#4466
Closes#4206

@npm-robot
Copy link
Contributor

npm-robot commented Mar 22, 2022

found 2 benchmarks with statistically significant performance regressions

  • app-large: clean, no-clean:audit
timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@853.528 ±1.9734.176 ±0.7930.485 ±13.1323.949 ±1.203.373 ±0.003.530 ±0.062.853 ±0.0614.032 ±0.022.836 ±0.033.862 ±0.10
#459459.775 ±1.5734.754 ±0.1821.901 ±0.9624.484 ±1.223.643 ±0.113.626 ±0.172.788 ±0.0414.509 ±0.002.915 ±0.014.297 ±0.16
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@843.734 ±2.7526.167 ±0.1915.547 ±0.2616.923 ±0.553.173 ±0.023.316 ±0.072.988 ±0.0010.622 ±0.052.695 ±0.043.689 ±0.04
#459446.480 ±0.4626.839 ±0.2016.371 ±0.1116.966 ±0.173.249 ±0.173.136 ±0.032.975 ±0.2210.609 ±0.032.686 ±0.013.614 ±0.10

@lukekarryslukekarrysforce-pushed the lk/redact-log branch 8 times, most recently from bc5d02b to 4a6a890CompareMarch 22, 2022 05:38
@lukekarryslukekarrys marked this pull request as ready for review March 22, 2022 05:38
@lukekarryslukekarrys requested a review from a team as a code ownerMarch 22, 2022 05:38
Copy link
Member

@wraithgarwraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good cleanup in this feat.

@lukekarryslukekarrysforce-pushed the lk/redact-log branch 2 times, most recently from 6071834 to 4f98842CompareMarch 23, 2022 00:58
@lukekarrys
Copy link
ContributorAuthor

Just a note that this PR should probably be rebased, as I added the deps as separate commits.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Custom logging location [QUESTION] How to disable creating of verbose log files for every npm command?

4 participants

@lukekarrys@npm-robot@wraithgar@fritzy