Skip to content

Conversation

@npm-robot
Copy link
Contributor

v8.6.0 (2022-03-31)

Features

Bug Fixes

Documentation

Dependencies

@nodejs-github-botnodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Mar 31, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

bnb
bnb approved these changes Apr 1, 2022
Copy link
Contributor

@bnbbnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@VoltrexKeyvaVoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

If we want the commit queue to be able to land this we'll need to land nodejs/node-core-utils#614 (or something similar) in node-core-utils.

@VoltrexKeyvaVoltrexKeyva removed the needs-ci PRs that need a full CI run. label Apr 1, 2022
@ljharb
Copy link
Member

It'd be great to land this ASAP; node 17 has a very outdated npm rn.

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2022
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 9, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42550 ✔ Done loading data for nodejs/node/pull/42550 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 8.6.0 (#42550) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-robot:npm-8.6.0 -> nodejs:master Labels npm, fast-track, dont-land-on-v12.x, dont-land-on-v14.x, lts-watch-v16.x Commits 1 - deps: upgrade npm to 8.6.0 Committers 1 - npm team PR-URL: https://github.com/nodejs/node/pull/42550 Fixes: https://github.com/remove Fixes: https://github.com/100% Fixes: https://github.com/make Fixes: https://github.com/move Fixes: https://github.com/really Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/bump Fixes: https://github.com/return Fixes: https://github.com/consolidate Fixes: https://github.com/work Fixes: https://github.com/only Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tierney Cyren Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42550 Fixes: https://github.com/remove Fixes: https://github.com/100% Fixes: https://github.com/make Fixes: https://github.com/move Fixes: https://github.com/really Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/bump Fixes: https://github.com/return Fixes: https://github.com/consolidate Fixes: https://github.com/work Fixes: https://github.com/only Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tierney Cyren Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 31 Mar 2022 22:43:19 GMT ✔ Approvals: 7 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-928307710 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42550#pullrequestreview-928452353 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474922 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474971 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-928811578 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-929040706 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-929693993 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-01T08:44:02Z: https://ci.nodejs.org/job/node-test-pull-request/43255/ - Querying data for job/node-test-pull-request/43255/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42550 From https://github.com/nodejs/node * branch refs/pull/42550/merge -> FETCH_HEAD ✔ Fetched commits as be011858446f..6235b690371c -------------------------------------------------------------------------------- [master d81bef3ccd] deps: upgrade npm to 8.6.0 Author: npm team Date: Thu Mar 31 22:43:17 2022 +0000 203 files changed, 4669 insertions(+), 3415 deletions(-) delete mode 100644 deps/npm/lib/utils/deref-command.js delete mode 100644 deps/npm/lib/utils/is-windows-bash.js delete mode 100644 deps/npm/lib/utils/is-windows-shell.js delete mode 100644 deps/npm/lib/utils/path.js rewrite deps/npm/lib/utils/replace-info.js (82%) delete mode 100644 deps/npm/lib/utils/split-package-names.js delete mode 100644 deps/npm/lib/utils/unsupported.js delete mode 100644 deps/npm/lib/utils/usage.js delete mode 100644 deps/npm/lib/utils/with-chown-sync.js create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/common/owner-sync.js create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/with-owner-sync.js create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/with-owner.js delete mode 100644 deps/npm/node_modules/builtins/History.md rewrite deps/npm/node_modules/builtins/Readme.md (87%) delete mode 100644 deps/npm/node_modules/builtins/builtins.json create mode 100644 deps/npm/node_modules/builtins/index.js delete mode 100644 deps/npm/node_modules/builtins/test.js create mode 100644 deps/npm/node_modules/just-diff-apply/index.d.ts create mode 100644 deps/npm/node_modules/just-diff-apply/index.tests.ts create mode 100644 deps/npm/node_modules/make-fetch-happen/lib/dns.js create mode 100644 deps/npm/node_modules/npm-package-arg/README.md create mode 100644 deps/npm/node_modules/npm-registry-fetch/lib/clean-url.js delete mode 100644 deps/npm/node_modules/npm-registry-fetch/lib/silentlog.js rename deps/npm/node_modules/validate-npm-package-name/{=> lib}/index.js (83%) delete mode 100644 deps/npm/node_modules/validate-npm-package-name/test/index.js delete mode 100644 deps/npm/tap-snapshots/test/lib/commands/unpublish.js.test.cjs create mode 100644 deps/npm/tap-snapshots/test/lib/commands/version.js.test.cjs rewrite deps/npm/tap-snapshots/test/lib/utils/log-file.js.test.cjs (82%) rewrite deps/npm/test/coverage-map.js (78%) create mode 100644 deps/npm/test/fixtures/tspawk.js rewrite deps/npm/test/lib/commands/bin.js (93%) rewrite deps/npm/test/lib/commands/edit.js (90%) rewrite deps/npm/test/lib/commands/unpublish.js (73%) delete mode 100644 deps/npm/test/lib/load-all.js delete mode 100644 deps/npm/test/lib/utils/deref-command.js delete mode 100644 deps/npm/test/lib/utils/is-windows-bash.js delete mode 100644 deps/npm/test/lib/utils/is-windows-shell.js rewrite deps/npm/test/lib/utils/is-windows.js (92%) delete mode 100644 deps/npm/test/lib/utils/path.js delete mode 100644 deps/npm/test/lib/utils/split-package-names.js delete mode 100644 deps/npm/test/lib/utils/unsupported.js ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- deps: upgrade npm to 8.6.0 

PR-URL: #42550
Fixes: https://github.com/remove
Fixes: https://github.com/100%
Fixes: https://github.com/make
Fixes: https://github.com/move
Fixes: https://github.com/really
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/consolidate
Fixes: https://github.com/bump
Fixes: https://github.com/return
Fixes: https://github.com/consolidate
Fixes: https://github.com/work
Fixes: https://github.com/only
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Mestery [email protected]
Reviewed-By: Mohammed Keyvanzadeh [email protected]
Reviewed-By: Tierney Cyren [email protected]
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Darshan Sen [email protected]

[master a7e9a0a9b7] deps: upgrade npm to 8.6.0
Author: npm team [email protected]
Date: Thu Mar 31 22:43:17 2022 +0000
203 files changed, 4669 insertions(+), 3415 deletions(-)
delete mode 100644 deps/npm/lib/utils/deref-command.js
delete mode 100644 deps/npm/lib/utils/is-windows-bash.js
delete mode 100644 deps/npm/lib/utils/is-windows-shell.js
delete mode 100644 deps/npm/lib/utils/path.js
rewrite deps/npm/lib/utils/replace-info.js (82%)
delete mode 100644 deps/npm/lib/utils/split-package-names.js
delete mode 100644 deps/npm/lib/utils/unsupported.js
delete mode 100644 deps/npm/lib/utils/usage.js
delete mode 100644 deps/npm/lib/utils/with-chown-sync.js
create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/common/owner-sync.js
create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/with-owner-sync.js
create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/with-owner.js
delete mode 100644 deps/npm/node_modules/builtins/History.md
rewrite deps/npm/node_modules/builtins/Readme.md (87%)
delete mode 100644 deps/npm/node_modules/builtins/builtins.json
create mode 100644 deps/npm/node_modules/builtins/index.js
delete mode 100644 deps/npm/node_modules/builtins/test.js
create mode 100644 deps/npm/node_modules/just-diff-apply/index.d.ts
create mode 100644 deps/npm/node_modules/just-diff-apply/index.tests.ts
create mode 100644 deps/npm/node_modules/make-fetch-happen/lib/dns.js
create mode 100644 deps/npm/node_modules/npm-package-arg/README.md
create mode 100644 deps/npm/node_modules/npm-registry-fetch/lib/clean-url.js
delete mode 100644 deps/npm/node_modules/npm-registry-fetch/lib/silentlog.js
rename deps/npm/node_modules/validate-npm-package-name/{=> lib}/index.js (83%)
delete mode 100644 deps/npm/node_modules/validate-npm-package-name/test/index.js
delete mode 100644 deps/npm/tap-snapshots/test/lib/commands/unpublish.js.test.cjs
create mode 100644 deps/npm/tap-snapshots/test/lib/commands/version.js.test.cjs
rewrite deps/npm/tap-snapshots/test/lib/utils/log-file.js.test.cjs (82%)
rewrite deps/npm/test/coverage-map.js (78%)
create mode 100644 deps/npm/test/fixtures/tspawk.js
rewrite deps/npm/test/lib/commands/bin.js (93%)
rewrite deps/npm/test/lib/commands/edit.js (90%)
rewrite deps/npm/test/lib/commands/unpublish.js (73%)
delete mode 100644 deps/npm/test/lib/load-all.js
delete mode 100644 deps/npm/test/lib/utils/deref-command.js
delete mode 100644 deps/npm/test/lib/utils/is-windows-bash.js
delete mode 100644 deps/npm/test/lib/utils/is-windows-shell.js
rewrite deps/npm/test/lib/utils/is-windows.js (92%)
delete mode 100644 deps/npm/test/lib/utils/path.js
delete mode 100644 deps/npm/test/lib/utils/split-package-names.js
delete mode 100644 deps/npm/test/lib/utils/unsupported.js
✖ a7e9a0a9b7c8395b45229c8f09f7827f0ff51907
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 1:8 PR-URL is valid. pr-url
✖ 2:7 Fixes must be a GitHub URL. fixes-url
✖ 3:7 Fixes must be a GitHub URL. fixes-url
✖ 4:7 Fixes must be a GitHub URL. fixes-url
✖ 5:7 Fixes must be a GitHub URL. fixes-url
✖ 6:7 Fixes must be a GitHub URL. fixes-url
✖ 7:7 Fixes must be a GitHub URL. fixes-url
✖ 7:7 Fixes must be a GitHub URL. fixes-url
✖ 7:7 Fixes must be a GitHub URL. fixes-url
✖ 7:7 Fixes must be a GitHub URL. fixes-url
✖ 7:7 Fixes must be a GitHub URL. fixes-url
✖ 11:7 Fixes must be a GitHub URL. fixes-url
✖ 12:7 Fixes must be a GitHub URL. fixes-url
✖ 14:7 Fixes must be a GitHub URL. fixes-url
✖ 15:7 Fixes must be a GitHub URL. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/2140194832

targos pushed a commit that referenced this pull request Apr 9, 2022
PR-URL: #42550 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targos
Copy link
Member

Landed in 2d84620

@targostargos closed this Apr 9, 2022
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#42550 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2022
PR-URL: #42550 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
ruyadorno pushed a commit that referenced this pull request May 27, 2022
PR-URL: #42550 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@ruyadornoruyadorno mentioned this pull request May 30, 2022
@juanarboljuanarbol mentioned this pull request Jun 1, 2022
@wraithgarwraithgar deleted the npm-8.6.0 branch June 26, 2025 15:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.fast-trackPRs that do not need to wait for 48 hours to land.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@npm-robot@nodejs-github-bot@richardlau@ljharb@targos@bnb@Trott@cjihrig@RaisinTen@Mesteery@VoltrexKeyva