Skip to content

Conversation

@wraithgar
Copy link
Member

@wraithgarwraithgar commented Mar 23, 2022

Lots of fixes here, please do not squash-merge this.

@wraithgarwraithgar requested a review from a team as a code ownerMarch 23, 2022 22:25
@wraithgar
Copy link
MemberAuthor

This was branched off of #4607, so that needs to land first then this can be rebased.

@wraithgarwraithgar marked this pull request as draft March 24, 2022 13:53
@npm-robot
Copy link
Contributor

npm-robot commented Mar 24, 2022

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@864.049 ±3.9441.524 ±0.0925.311 ±0.2427.958 ±0.674.031 ±0.004.127 ±0.023.163 ±0.0616.860 ±0.163.236 ±0.004.439 ±0.03
#460968.968 ±5.3041.604 ±0.2425.080 ±0.3927.991 ±0.793.975 ±0.024.082 ±0.153.150 ±0.0416.960 ±0.203.221 ±0.014.756 ±0.34
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@847.097 ±1.8931.682 ±0.4617.989 ±0.0819.061 ±0.143.640 ±0.023.613 ±0.023.190 ±0.1612.169 ±0.253.002 ±0.024.130 ±0.03
#460948.949 ±1.0632.335 ±0.4123.490 ±6.9519.733 ±0.263.601 ±0.003.549 ±0.083.139 ±0.1012.121 ±0.102.987 ±0.004.003 ±0.04

@wraithgarwraithgarforce-pushed the gar/aliases branch 8 times, most recently from ed9faf6 to 33b67beCompareMarch 24, 2022 20:02
@wraithgarwraithgar marked this pull request as ready for review March 24, 2022 21:06
nlf
nlf approved these changes Mar 24, 2022
@lukekarryslukekarrys merged commit 738a404 into latestMar 28, 2022
@lukekarryslukekarrys deleted the gar/aliases branch March 28, 2022 20:21
@lukekarryslukekarrys mentioned this pull request Mar 31, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wraithgar@npm-robot@nlf@lukekarrys