Skip to content

Conversation

@wraithgar
Copy link
Member

@wraithgarwraithgar commented Mar 23, 2022

  • Removed dead code in lib/utils/usage.js.
  • Removed dead code in lib/base-command.js.
  • Removed "load-all" test, we currently have 100% coverage and new PRs
    without tests will be rejected if they don't add coverage for new
    files.
  • Removed check-coverage script as a separate command.
  • Removed separate coverage test in ci.yml.
  • Removed coverage flag from tap config, the default is already to
    enforce 100% coverage.

Added another commit that cleans up usage, which removing the dead code from base-command revealed as being needed.

  • Removed usage lib, rolled logic into base-command.js
  • Cleaned up usage output to be less redundant

@wraithgarwraithgar requested a review from a team as a code ownerMarch 23, 2022 18:22
@npm-robot
Copy link
Contributor

npm-robot commented Mar 23, 2022

found 1 benchmarks with statistically significant performance regressions

  • app-large: no-clean:audit
timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@854.614 ±2.7236.328 ±0.7322.541 ±0.5725.401 ±1.453.528 ±0.053.611 ±0.002.925 ±0.0914.539 ±0.012.855 ±0.033.980 ±0.02
#460756.995 ±0.5836.619 ±0.0522.444 ±0.5326.387 ±0.833.681 ±0.023.749 ±0.112.924 ±0.0215.505 ±0.312.969 ±0.064.521 ±0.31
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@839.577 ±0.3727.423 ±0.5215.887 ±0.5817.303 ±0.393.297 ±0.053.353 ±0.052.993 ±0.0711.237 ±0.272.744 ±0.023.776 ±0.02
#460741.724 ±0.7128.645 ±0.0716.589 ±0.0118.132 ±0.153.346 ±0.043.403 ±0.072.987 ±0.0411.062 ±0.172.743 ±0.013.821 ±0.03

@wraithgarwraithgarforce-pushed the gar/coverage-map-update branch from 67b44a7 to 655aec8CompareMarch 23, 2022 19:58
@wraithgarwraithgar mentioned this pull request Mar 23, 2022
@ruyadornoruyadorno added semver:patch semver patch level for changes Release 8.x work is associated with a specific npm 8 release release: next These items should be addressed in the next release labels Mar 24, 2022
 * Removed dead code in `lib/utils/usage.js`. * Removed dead code in `lib/base-command.js`. * Removed "load-all" test, we currently have 100% coverage and new PRs without tests will be rejected if they don't add coverage for new files. * Removed `check-coverage` script as a separate command. * Removed separate coverage test in ci.yml. * Removed `coverage` flag from tap config, the default is already to enforce 100% coverage. Removed a tiny bit of dead code resulting from this
@wraithgarwraithgarforce-pushed the gar/coverage-map-update branch from 655aec8 to 5649c30CompareMarch 24, 2022 16:11
Removed usage lib, rolled logic into base-command.js Cleaned up usage output to be less redundant
@wraithgarwraithgarforce-pushed the gar/coverage-map-update branch from 5649c30 to 38a97e6CompareMarch 24, 2022 16:15
@fritzyfritzy merged commit 716a07f into latestMar 24, 2022
@fritzyfritzy deleted the gar/coverage-map-update branch March 24, 2022 20:23
This was referenced Mar 29, 2022
@lukekarryslukekarrys mentioned this pull request Mar 31, 2022
@lukekarryslukekarrys mentioned this pull request Apr 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: nextThese items should be addressed in the next releaseRelease 8.xwork is associated with a specific npm 8 releasesemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wraithgar@npm-robot@ruyadorno@fritzy