protocol_version in http.server.test can be ignored

[openalmeida]

BPO	46285
Nosy	@merwok, @matrixise, @JelleZijlstra, @maggyero, @openalmeida
PRs	bpo-46285: Add command-line option -p/--protocol to module http.server #30999
Dependencies	bpo-46436: Pass the -d/--directory command-line option to http.server.CGIHTTPRequestHandler
Files	my_http.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2022-01-06.18:39:21.504>
labels = ['type-feature', 'library', '3.11']
title = 'protocol_version in http.server.test can be ignored'
updated_at = <Date 2022-02-03.15:57:34.891>
user = 'https://github.com/openalmeida'

bugs.python.org fields:

activity = <Date 2022-02-03.15:57:34.891>
actor = 'eric.araujo'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2022-01-06.18:39:21.504>
creator = 'openalmeida'
dependencies = ['46436']
files = ['50551']
hgrepos = []
issue_num = 46285
keywords = ['patch']
message_count = 11.0
messages = ['409894', '409899', '410012', '410015', '410107', '410161', '410163', '411310', '411392', '411841', '411887']
nosy_count = 5.0
nosy_names = ['eric.araujo', 'matrixise', 'JelleZijlstra', 'maggyero', 'openalmeida']
pr_nums = ['30999']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue46285'
versions = ['Python 3.11']

[openalmeida]

Hi,

Sorry for my poor English, this is not a spam issue.

How to reproduce
================

File about http/server.py, line 1235 at main branch.

1st, change protocol_version, e.g. from "HTTP/1.0" to "HTTP/1.1":
--- protocol="HTTP/1.0", port=8000, ...
+++ protocol="HTTP/1.1", port=8000, ...

2ed, run with python -m http.server and test by: curl http://127.0.0.1:8000 2>/dev/null| head -n 1

Result
======

The response head line will always been a fixed HTTP Version refer to BaseHTTPRequestHandler.protocol_version defined, thus "HTTP/1.0 200 OK" currently.

Expected
========

It should equal to http.server.test(protocol="...") which specified like above, for this issue, it is expected to be "HTTP/1.1 200 OK".

P.S.
====

I know it is just locate in a test code area (http.servers::test), but what I submit here is about a Python Variable Scope issue maybe.

[openalmeida]

update
======

It seems I've found the problem, http/server.py#L1277-L1288:

 handler_class = partial(SimpleHTTPRequestHandler,
 directory=args.directory)

Because of partial (provide by the functools module), there comes a closure like stuff ?

[merwok]

Hello and thanks for the report!

Could you tell more about what you’re trying to achieve?

Some notes:

You are not meant to change the code of provided modules, but to instantiate classes with the right parameters, or subclass in your own code to change how some methods work.

Supporting HTTP 1/1 is not just changing the protocol string, but also about supporting the actual behaviours defined in the 1.1 spec!

If the module has a parameter for version and it doesn’t work, then you can report a bug. If there is no such parameter, you can open a feature request to ask for HTTP 1.1 support.

[merwok]

I understand your report better after looking at the code.

There is indeed a protocol_version parameter in the test function (which is really a main function, not test), that sets the protocol attribute on the passed handler class. (The class attribute is changed, which seems like a bug!) The BaseHTTPRequestHandler class does have support for HTTP 1.1 (adds automatic keep-alive).

So if we ignore the distraction that OP changed the source code, and imaging instead that they called test(protocol="HTTP/1.1"), then there would be a bug if the requests went out as HTTP/1.0.

Hugo, can you attach a minimal reproducer? (a python script as small as possible to show the problem — don’t edit code in http.server but call the http.server.test function with your own code)

[openalmeida]

The short story is, everything is okay,
its my bad to taken the test function out of context,
sorry about that of issue report.

just for details review (related file attached):

check line 1277 to line 1278 (main branch of Python currently):

https://github.com/python/cpython/blob/17b16e1/Lib/http/server.py#L1277-L1278

thus, functools.partial (closure/wrapper) will

make the parameter protocol of the function test useless.

So, specify a handler class directly.