Skip to content

Conversation

@geryogam
Copy link
Contributor

@geryogamgeryogam commented Jan 28, 2022

This PR will add command-line option -p/--protocol to module http.server which specifies the HTTP version to which the server is conformant (HTTP/1.1 servers can now be run from the command-line interface of module http.server):

python -m http.server --protocol HTTP/1.1

https://bugs.python.org/issue46285

@merwok
Copy link
Member

Thanks for the the PR! Let’s merge this one after the bug fix to the same module.

@geryogamgeryogamforce-pushed the patch-26 branch 3 times, most recently from 5323621 to f5e0dc4CompareJanuary 30, 2022 23:38
@merwokmerwok self-assigned this Jan 31, 2022
@merwok
Copy link
Member

Please avoid rebases and force-pushes for CPython, github does not have a good experience for reviewers.
Regular merges are also easier to do!

@merwokmerwok requested a review from orsenthilMay 1, 2022 12:24
Copy link
Member

@orsenthilorsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I had a brief hesitancy for exposing this protocol version via flag as the support is not comprehensive. I am pretty sure we are missing many features.

But given that class supports .protocol_version as a attribute, exposing it via a command line flag is alright.

@JelleZijlstraJelleZijlstra self-assigned this May 2, 2022
@JelleZijlstraJelleZijlstra merged commit 2d30ade into python:mainMay 2, 2022
@geryogam
Copy link
ContributorAuthor

Thanks @merwok, @JelleZijlstra, and @orsenthil for the review!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@geryogam@merwok@orsenthil@JelleZijlstra@the-knights-who-say-ni@bedevere-bot