gh-101440: fix json snippet error in logging-cookbook.rst#101439
Merged
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
peterjpxie changed the title 
rhettinger approved these changes Jan 30, 2023
hugovk added needs backport to 3.10 
hugovk approved these changes Jan 31, 2023
sobolevn approved these changes Jan 31, 2023
Member
sobolevn left a comment
sobolevn left a comment There was a problem hiding this comment.
This was not a valid JSON, trailing commas are not allowed (except for json5).
Thanks!
Contributor
miss-islington commented Jan 31, 2023
Thanks @peterjpxie for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commented Jan 31, 2023
GH-101463 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
…onGH-101439) (cherry picked from commit 20c11f2) Co-authored-by: Peter Jiping Xie <peter.jp.xie@gmail.com>
bedevere-bot commented Jan 31, 2023
GH-101464 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
…onGH-101439) (cherry picked from commit 20c11f2) Co-authored-by: Peter Jiping Xie <peter.jp.xie@gmail.com>
miss-islington added a commit that referenced this pull request Jan 31, 2023
miss-islington added a commit that referenced this pull request Jan 31, 2023
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
carljm added a commit to carljm/cpython that referenced this pull request Jan 31, 2023
* main: pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439) pythongh-99276 - Updated Doc/faq/general.rst (python#101396) Add JOBS parameter to docs Makefile (python#101395) pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443) pythongh-77607: Improve accuracy of os.path.join docs (python#101406) Fixes typo in asyncio.TaskGroup context manager code example (python#101449) pythongh-98831: Clean up and add cache size static_assert to macro (python#101442) pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the extra comma (,)