gh-102304: Move _Py_RefTotal to _PyRuntimeState#102543
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
ericsnowcurrently commented Mar 8, 2023
ericsnowcurrentlyforce-pushed the consolidate-py-reftotal branch from 8af10a5 to f382c4aCompareericsnowcurrently added the 🔨 test-with-refleak-buildbots 
bedevere-bot commented Mar 17, 2023
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 2fb3259 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot removed the 🔨 test-with-refleak-buildbots MemberAuthor
ericsnowcurrently commented Mar 20, 2023
All the refleak buildbots are happy with this PR. |
bedevere-bot commented Mar 20, 2023
|
bedevere-bot commented Mar 20, 2023
|
MemberAuthor
ericsnowcurrently commented Mar 20, 2023
gh-102846 should take care of those buildbots. |
ericsnowcurrently added a commit that referenced this pull request Mar 20, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
The essentially eliminates the global variable, with the associated benefits. This is also a precursor to isolating this bit of state to PyInterpreterState. Folks that currently read _Py_RefTotal directly would have to start using _Py_GetGlobalRefTotal() instead. python#102304
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
Some debug-only code slipped in with pythongh-102543. python#102304
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
The essentially eliminates the global variable, with the associated benefits. This is also a precursor to isolating this bit of state to PyInterpreterState. Folks that currently read _Py_RefTotal directly would have to start using _Py_GetGlobalRefTotal() instead. python#102304
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
Some debug-only code slipped in with pythongh-102543. python#102304
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The essentially eliminates the global variable, with the associated benefits. This is also a precursor to isolating this bit of state to
PyInterpreterState.Folks that currently read
_Py_RefTotaldirectly would have to start using_Py_GetGlobalRefTotal()instead.