gh-102304: Move the Total Refcount to PyInterpreterState#102545
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ericsnowcurrentlyforce-pushed the isolate-pyreftotal branch 2 times, most recently from b3bb5e5 to 668eb4cCompareMemberAuthor
FYI, I'm probably going to add some code to preserve the per-interpreter total when each subinterpreter is destroyed, so any leaks may be handled appropriately when the runtime is finalized. I may also report the per-interpreter total at interpreter finalization. We'll see. |
ericsnowcurrentlyforce-pushed the isolate-pyreftotal branch 3 times, most recently from 780e7ec to 68da9daCompareericsnowcurrentlyforce-pushed the isolate-pyreftotal branch from 68da9da to f64202dCompareericsnowcurrently added the 🔨 test-with-refleak-buildbots 
bedevere-bot commented Mar 20, 2023
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 475db68 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot removed the 🔨 test-with-refleak-buildbots MemberAuthor
ericsnowcurrently commented Mar 21, 2023
The refleak buildbots all look good. |
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
…ngh-102545) Moving it valuable with a per-interpreter GIL. However, it is also useful without one, since it allows us to identify refleaks within a single interpreter or where references are escaping an interpreter. This becomes more important as we move the obmalloc state to PyInterpreterState. python#102304
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
…ngh-102545) Moving it valuable with a per-interpreter GIL. However, it is also useful without one, since it allows us to identify refleaks within a single interpreter or where references are escaping an interpreter. This becomes more important as we move the obmalloc state to PyInterpreterState. python#102304
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving it valuable with a per-interpreter GIL. However, it is also useful without one, since it allows us to identify refleaks within a single interpreter or where references are escaping an interpreter. This becomes more important as we move the obmalloc state to
PyInterpreterState.(This PR is basically a single commit on top of gh-102543.)