gh-104692: Include commoninstall as a prerequisite for bininstall#104693
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bedevere-bot commented May 20, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
All commit authors signed the Contributor License Agreement. |
This ensures that `commoninstall` is completed before `bininstall` is started when parallel builds are used (`make -j install`), and so the `python3` symlink is only installed after all standard library modules are installed.
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request May 20, 2023
When doing parallel builds, host Python can install the python3 symlink before the Python standard library is installed completely. When this occurs, it is possible for other packages to detect the python3 symlink and try to use host Python before it is fully installed. This adds a patch to make commoninstall (where the standard library is installed) a prerequisite of bininstall (where the python3 symlink is installed), so that commoninstall is fully completed before bininstall begins. Patch has been submitted upstream: python/cpython#104693Fixes: openwrt#19241 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
arhadthedev added build 
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request May 22, 2023
When doing parallel builds, host Python can install the python3 symlink before the Python standard library is installed completely. When this occurs, it is possible for other packages to detect the python3 symlink and try to use host Python before it is fully installed. This adds a patch to make commoninstall (where the standard library is installed) a prerequisite of bininstall (where the python3 symlink is installed), so that commoninstall is fully completed before bininstall begins. Patch has been submitted upstream: python/cpython#104693Fixes: openwrt#19241 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request May 23, 2023
When doing parallel builds, host Python can install the python3 symlink before the Python standard library is installed completely. When this occurs, it is possible for other packages to detect the python3 symlink and try to use host Python before it is fully installed. This adds a patch to make commoninstall (where the standard library is installed) a prerequisite of bininstall (where the python3 symlink is installed), so that commoninstall is fully completed before bininstall begins. Patch has been submitted upstream: python/cpython#104693Fixes: openwrt#19241 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
neheb pushed a commit to openwrt/packages that referenced this pull request May 24, 2023
When doing parallel builds, host Python can install the python3 symlink before the Python standard library is installed completely. When this occurs, it is possible for other packages to detect the python3 symlink and try to use host Python before it is fully installed. This adds a patch to make commoninstall (where the standard library is installed) a prerequisite of bininstall (where the python3 symlink is installed), so that commoninstall is fully completed before bininstall begins. Patch has been submitted upstream: python/cpython#104693Fixes: #19241 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request May 24, 2023
When doing parallel builds, host Python can install the python3 symlink before the Python standard library is installed completely. When this occurs, it is possible for other packages to detect the python3 symlink and try to use host Python before it is fully installed. This adds a patch to make commoninstall (where the standard library is installed) a prerequisite of bininstall (where the python3 symlink is installed), so that commoninstall is fully completed before bininstall begins. Patch has been submitted upstream: python/cpython#104693Fixes: openwrt#19241 Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit 67e47f1)
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request May 24, 2023
When doing parallel builds, host Python can install the python3 symlink before the Python standard library is installed completely. When this occurs, it is possible for other packages to detect the python3 symlink and try to use host Python before it is fully installed. This adds a patch to make commoninstall (where the standard library is installed) a prerequisite of bininstall (where the python3 symlink is installed), so that commoninstall is fully completed before bininstall begins. Patch has been submitted upstream: python/cpython#104693Fixes: openwrt#19241 Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit 67e47f1) Signed-off-by: Jeffery To <jeffery.to@gmail.com>
graysky2 pushed a commit to graysky2/packages that referenced this pull request May 25, 2023
When doing parallel builds, host Python can install the python3 symlink before the Python standard library is installed completely. When this occurs, it is possible for other packages to detect the python3 symlink and try to use host Python before it is fully installed. This adds a patch to make commoninstall (where the standard library is installed) a prerequisite of bininstall (where the python3 symlink is installed), so that commoninstall is fully completed before bininstall begins. Patch has been submitted upstream: python/cpython#104693Fixes: openwrt#19241 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
zware reviewed May 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
Add an explanation for why commoninstall is made a prerequisite of bininstall. Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
Contributor
miss-islington commented Jun 7, 2023
Thanks @jefferyto for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Contributor
miss-islington commented Jun 7, 2023
Sorry @jefferyto and @ambv, I had trouble checking out the |
Contributor
miss-islington commented Jun 7, 2023
Sorry, @jefferyto and @ambv, I could not cleanly backport this to |
jefferyto added a commit to jefferyto/cpython that referenced this pull request Jun 7, 2023
…ininstall (pythonGH-104693) This ensures that `commoninstall` is completed before `bininstall` is started when parallel builds are used (`make -j install`), and so the `python3` symlink is only installed after all standard library modules are installed. Co-authored-by: Zachary Ware <zachary.ware@gmail.com> (cherry picked from commit 990cb36) Co-authored-by: Jeffery To <jeffery.to@gmail.com>
bedevere-bot commented Jun 7, 2023
GH-105428 is a backport of this pull request to the 3.12 branch. |
bedevere-bot commented Jun 7, 2023
GH-105429 is a backport of this pull request to the 3.11 branch. |
bedevere-bot commented Jun 7, 2023
GH-105428 is a backport of this pull request to the 3.12 branch. |
jefferyto added a commit to jefferyto/cpython that referenced this pull request Jun 7, 2023
…ininstall (pythonGH-104693) This ensures that `commoninstall` is completed before `bininstall` is started when parallel builds are used (`make -j install`), and so the `python3` symlink is only installed after all standard library modules are installed. Co-authored-by: Zachary Ware <zachary.ware@gmail.com>. (cherry picked from commit 990cb36) Co-authored-by: Jeffery To <jeffery.to@gmail.com>
bedevere-bot commented Jun 7, 2023
GH-105429 is a backport of this pull request to the 3.11 branch. |
ContributorAuthor
jefferyto commented Jul 4, 2023
Is there anything else I should do to have the backports merged? |
ambv pushed a commit that referenced this pull request Jul 5, 2023
…all (GH-104693) (#105429) This ensures that `commoninstall` is completed before `bininstall` is started when parallel builds are used (`make -j install`), and so the `python3` symlink is only installed after all standard library modules are installed. . (cherry picked from commit 990cb36) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Contributor
ambv commented Jul 5, 2023
I merged them. |
lazka added a commit to lazka/MSYS2-packages that referenced this pull request Aug 28, 2023
960-fix-parallel-make.patch: fixed upstream python/cpython#104693
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request Sep 5, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request Sep 5, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
1715173329 pushed a commit to openwrt/packages that referenced this pull request Sep 8, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request Sep 12, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit e42c845)
BKPepe pushed a commit to openwrt/packages that referenced this pull request Sep 14, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit e42c845)
lu-zero pushed a commit to domo-iot/packages that referenced this pull request Oct 23, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that
commoninstallis completed beforebininstallis started when parallel builds are used (make -j install), and so thepython3symlink is only installed after all standard library modules are installed.