gh-90005: Don't link with libbsd if not needed#105236
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Restore pre pythongh-29696 behaviour
ContributorAuthor
erlend-aasland commented Jun 2, 2023
@jefferyto, does this work for you? (re #29696 (comment)) |
Contributor
jefferyto commented Jun 6, 2023
Checking config.log after a test build with this change, I no longer see a check for libbsd after the flock function check is successful (and no |
erlend-aasland added needs backport to 3.11 
Contributor
miss-islington commented Jun 6, 2023
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Contributor
miss-islington commented Jun 6, 2023
Sorry @erlend-aasland, I had trouble checking out the |
Contributor
miss-islington commented Jun 6, 2023
Sorry, @erlend-aasland, I could not cleanly backport this to |
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 6, 2023
…05236) The regression was introduced with commit 5b946ca. Restore pre pythongh-29696 behaviour.
ContributorAuthor
erlend-aasland commented Jun 6, 2023
Thanks for the report, @jefferyto! |
bedevere-bot commented Jun 6, 2023
GH-105359 is a backport of this pull request to the 3.11 branch. |
bedevere-bot commented Jun 6, 2023
GH-105360 is a backport of this pull request to the 3.12 branch. |
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 6, 2023
…05236) The regression was introduced with commit 5b946ca. Restore pre pythongh-29696 behaviour.
erlend-aasland added a commit that referenced this pull request Jun 6, 2023
erlend-aasland added a commit that referenced this pull request Jun 6, 2023
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request Sep 5, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request Sep 5, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
1715173329 pushed a commit to openwrt/packages that referenced this pull request Sep 8, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
jefferyto added a commit to jefferyto/openwrt-packages that referenced this pull request Sep 12, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit e42c845)
BKPepe pushed a commit to openwrt/packages that referenced this pull request Sep 14, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit e42c845)
lu-zero pushed a commit to domo-iot/packages that referenced this pull request Oct 23, 2023
Includes fix for CVE-2023-40217 (Bypass TLS handshake on closed sockets). This also: * Remove 027-install-python3-symlink-after-stdlib.patch This was merged upstream in python/cpython#104693. * Remove fix for unnecessary linking with libbsd (60bf01c) This was fixed upstream in python/cpython#105236. Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore pre gh-29696 behaviour