gh-104372: Use non-Raw malloc for c_fds_to_keep in _posixsubprocess#104697
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
As the code could ask for 0 length.
gpshead added a commit to gpshead/cpython that referenced this pull request May 23, 2023
Backport of d1732fe to 3.11 from python#104697.
gpshead added a commit that referenced this pull request May 24, 2023
… signal safety gh-104518 (#104785) Move all of the Python C API calls into the parent process up front instead of doing PyLong_AsLong and PyErr_Occurred and PyTuple_GET from the post-fork/vfork child process. Much of this was long overdue. We shouldn't have been using PyTuple and PyLong APIs within all of these low level functions anyways. This is a backport of c649df6 for #104518 and the tiny adjustment in d1732fe #104697. Backporting this allows backporting of the real bug fix that requires it. Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
Member
vstinner commented May 24, 2023
PyMem_RawMalloc(0) is well defined: https://docs.python.org/dev/c-api/memory.html#c.PyMem_RawMalloc But I prefer to use PyMem_Malloc() when the GIL is held, it's usually faster ;-) |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the code could ask for 0 length.
This is a tiny fix to a theoretical issue with PR #104518.
vfork()until the child processexec()succeeds or fails. #104372