gh-104372: Drop the GIL around the vfork() call.#104782
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
On Linux where the `subprocess` module can use the `vfork` syscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child process `exec` outcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application. Fixespython#104372.
MemberAuthor
gpshead added needs backport to 3.11 Don't write to the vfork_tstate_save pointer local after vfork.
All commit authors signed the Contributor License Agreement. |
Yhg1s approved these changes May 24, 2023
Uh oh!
There was an error while loading. Please reload this page.
Contributor
miss-islington commented May 25, 2023
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Contributor
miss-islington commented May 25, 2023
Sorry, @gpshead, I could not cleanly backport this to |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
On Linux where the `subprocess` module can use the `vfork` syscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child process `exec` outcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application. FixespythonGH-104372. (cherry picked from commit d086792) Co-authored-by: Gregory P. Smith <gps@python.org>
bedevere-bot commented May 25, 2023
GH-104942 is a backport of this pull request to the 3.12 branch. |
gpshead added a commit that referenced this pull request May 25, 2023
…104942) gh-104372: Drop the GIL around the vfork() call. (GH-104782) On Linux where the `subprocess` module can use the `vfork` syscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child process `exec` outcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application. FixesGH-104372. (cherry picked from commit d086792) Co-authored-by: Gregory P. Smith <gps@python.org>
gpshead added a commit to gpshead/cpython that referenced this pull request May 26, 2023
On Linux where the `subprocess` module can use the `vfork` syscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child process `exec` outcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application. Fixespython#104372. (cherry picked from commit d086792)
bedevere-bot commented May 26, 2023
GH-104958 is a backport of this pull request to the 3.11 branch. |
gpshead added a commit that referenced this pull request Sep 1, 2023
…04958) gh-104372: Drop the GIL around the vfork() call. (#104782) On Linux where the `subprocess` module can use the `vfork` syscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child process `exec` outcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application. Fixes#104372. (cherry picked from commit d086792)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux where the
subprocessmodule can use thevforksyscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child processexecoutcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application.Fixes#104372.
vfork()until the child processexec()succeeds or fails. #104372