[3.11] gh-104372: Drop the GIL around the vfork() call. (#104782)#104958
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
On Linux where the `subprocess` module can use the `vfork` syscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child process `exec` outcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application. Fixespython#104372. (cherry picked from commit d086792)
MemberAuthor
gpshead commented May 30, 2023
I want to let this bake in some 3.12beta releases for a while before applying it to a stable release. thus "draft". |
Contributor
hauntsaninja commented Aug 30, 2023
3.12 is now at RC stage; should we merge to 3.11? |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux where the
subprocessmodule can use thevforksyscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child processexecoutcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application.Fixes#104372.
(cherry picked from commit d086792)
vfork()until the child processexec()succeeds or fails. #104372📚 Documentation preview 📚: https://cpython-previews--104958.org.readthedocs.build/