Skip to content

Use CSV-separated outputs @ get-changed-files @ CI #105151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 9 commits into from
Jun 21, 2023
Merged

Use CSV-separated outputs @ get-changed-files @ CI #105151

hugovk merged 9 commits into from
Jun 21, 2023

Conversation

@webknjaz
Copy link
Member

@webknjazwebknjaz commented May 31, 2023

This is necessary because paths with whitespaces tend to crash said
action[1][2][3]. Also, we don't need to use JSON as it's harder
to parse while the value isn't used except for the emptiness check.

The change fixes [4]. It also reverts commit 4c77061.

@webknjaz
Revert "CI: Temporarily skip paths with spaces to avoid error (python…
4b0020f
…#105110)" This reverts commit 4c77061.
@webknjaz
Use CSV-separated outputs @ get-changed-files @ CI
9517c21
This is necessary because paths with whitespaces tend to crash said action[[1]][[2]][[3]]. Also, we don't need to use JSON as it's harder to parse while the value isn't used except for the emptiness check. The change fixes [[4]] [1]: https://github.com/Ana06/get-changed-files#get-all-changed-files-as-space-delimited [2]: python#103914 (comment) [3]: python#103914 (comment) [4]: python#103914 (comment)
This was referenced May 31, 2023
Merged
Closed
@webknjaz
Copy link
MemberAuthor

webknjaz commented May 31, 2023

I've made a "demo PR" that should help verify that the fix is functional. It's here: #105153.

@webknjaz
Copy link
MemberAuthor

webknjaz commented May 31, 2023

I've made a "demo PR" that should help verify that the fix is functional. It's here: #105153.

UPD: it does work — https://github.com/python/cpython/actions/runs/5135145133/jobs/9240164159?pr=105153#step:5:17

cc @hugovk

@webknjazwebknjaz mentioned this pull request May 31, 2023
Merged
hugovk
hugovk reviewed May 31, 2023
View reviewed changes
@hugovkhugovk mentioned this pull request Jun 1, 2023
Merged
webknjaz
webknjaz commented Jun 4, 2023
View reviewed changes
webknjaz
webknjaz commented Jun 4, 2023
View reviewed changes
@webknjazwebknjaz requested a review from hugovkJune 4, 2023 21:16
@webknjaz
Copy link
MemberAuthor

webknjaz commented Jun 4, 2023

@hugovk I think this needs skip issue and skip news too.

hugovk
hugovk reviewed Jun 5, 2023
View reviewed changes
webknjazand others added 2 commits June 5, 2023 23:22
@webknjaz@hugovk
Refer to exit from sys explicitly
3e6f488
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk
Merge branch 'main' into maintenance/gha-reusable-docs-workflow--Ana0…
d19d319
…6--get-changed-files--output-format
hugovk
hugovk approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovkhugovk merged commit eaa6702 into python:mainJun 21, 2023
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 22, 2023
@webknjaz@hugovk
Use CSV-separated outputs @ get-changed-files @ CI (python#105151)
ee7a788
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit eaa6702)
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 22, 2023
@webknjaz@hugovk
Use CSV-separated outputs @ get-changed-files @ CI (python#105151)
aa38876
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit eaa6702)
This was referenced Jul 22, 2023
Merged
Merged
ambv pushed a commit that referenced this pull request Jul 23, 2023
@webknjaz
[3.11] Convertdoc.ymlworkflow to be reusable (GH-103914+GH-105151…
561029a
…) (#107043) Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>. (cherry picked from commit 88d14da) (cherry picked from commit eaa6702)
ambv pushed a commit that referenced this pull request Jul 23, 2023
@webknjaz
[3.12] Convertdoc.ymlworkflow to be reusable (GH-103914+GH-105151…
1703262
…) (#107042) Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit 88d14da) (cherry picked from commit eaa6702)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

No one assigned

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@webknjaz@hugovk@bedevere-bot