Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
Run sphinx-lint on Misc/NEWS.d/next/#108212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Although I do not see a difference in some files. Why are they marked as different?
hugovk commented Aug 21, 2023
They were "No newline at end of file": https://github.com/hugovk/cpython/actions/runs/5925848833/job/16066091943 |
hugovk commented Aug 21, 2023
The 3.12 backport will only need the first commit, I'll backport it manually. |
AlexWaygood left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few optional suggestions:
Misc/NEWS.d/next/Library/2023-07-14-16-54-13.gh-issue-106752.BT1Yxw.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Misc/NEWS.d/next/Library/2023-08-07-14-12-07.gh-issue-107715.238r2f.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot commented Aug 21, 2023
GH-108213 is a backport of this pull request to the 3.12 branch. |
bedevere-bot commented Aug 21, 2023
There's a new commit after the PR has been approved. @serhiy-storchaka, @AlexWaygood: please review the changes made to this pull request. |
…issue-105736.NJsH7r.rst (effectively a backport of pythonGH-108212).
Fix lint warnings in Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst (effectively a backport of GH-108212).
Follow on from #105750.
Before that PR, we used to run sphinx-lint on
Doc/andMisc/NEWS.d/next/After, we only ran sphinx-lint on
Doc/. I think leaving outMisc/NEWS.d/next/was an oversight on my part, let's add it back.In the meantime, a handful of NEWS warnings had slipped through, this PR also fixes them.