Skip to content

Conversation

@hugovk
Copy link
Member

No description provided.

@hugovk
Copy link
MemberAuthor

I'll follow this with a combined backport of #105750 and #108212.

I left them out of this one to keep things separate and clearer.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this diff is removing invisible pagebreak characters. For most of these cases, we should delete the whole line rather than just stripping the "trailing whitespace" from the line:

@AlexWaygood
Copy link
Member

See #102531 for where we removed invisible pagebreak characters from the main branch. (@hugovk, is it worth seeing if that PR could just be cleanly backported to 3.11?)

@hugovk
Copy link
MemberAuthor

Good idea, and it backported cleanly 🎉 #108266

@AlexWaygood

This comment was marked as outdated.

@hugovk
Copy link
MemberAuthor

Reverted Trim trailing whitespace, will update 3.11 into here, and then see what's left to fix.

@hugovk
Copy link
MemberAuthor

And autofixed via pre-commit, let's check these changes.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@hugovk
Copy link
MemberAuthor

And applied the two suggestions which were still available.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thank you!

@hugovkhugovk merged commit d678ee7 into python:3.11Aug 22, 2023
@hugovkhugovk deleted the 3.11-pre-commit branch August 22, 2023 09:57
@hugovk
Copy link
MemberAuthor

Thank you very much for the reviews!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@AlexWaygood@bedevere-bot