gh-108562: fix compiler warnings for bundled libmpdec in the main#114751
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This patch enable (if awailable) -fstrict-overflow for libmpdec and also shut off false positive warnings (-Warray-bounds). The later part was backported from mpdecimal-4.0.0.
skirpichevforce-pushed the enable-strict-overflow-108562 branch from 3303b02 to 8e514c5Compareskirpichev requested review from corona10, erlend-aasland, rhettinger and sethmlarson as code owners
erlend-aasland approved these changes Jan 30, 2024
sethmlarson approved these changes Jan 30, 2024
Contributor
sethmlarson left a comment
sethmlarson left a comment There was a problem hiding this comment.
Thanks for updating the SBOM!
erlend-aasland approved these changes Jan 30, 2024
MemberAuthor
skirpichev commented Mar 3, 2024
@erlend-aasland, is this still waiting for review? Maybe I should ask Stefan (However, I think the decimal-related part was actually discussed in the issue)? |
erlend-aasland approved these changes Mar 3, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
If awailable, enable -fstrict-overflow for libmpdec. Also shut off false positive warnings (-Warray-bounds). The later was backported from mpdecimal-4.0.0.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
If awailable, enable -fstrict-overflow for libmpdec. Also shut off false positive warnings (-Warray-bounds). The later was backported from mpdecimal-4.0.0.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
If awailable, enable -fstrict-overflow for libmpdec. Also shut off false positive warnings (-Warray-bounds). The later was backported from mpdecimal-4.0.0.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enable (if awailable) -fstrict-overflow for libmpdec and also shut off false positive warnings (-Warray-bounds). The later part was backported from mpdecimal-4.0.0.