gh-108562: Revert enabling -fstrict-overflow for libmpdec#116302
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Reverts -fstrict-overflow for libmpdec
erlend-aasland changed the title erlend-aasland changed the title 
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot commented Mar 4, 2024
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ca35e50 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
encukou commented Mar 4, 2024
(The |
Member
markshannon commented Mar 4, 2024
Is this ready to be merged? |
Member
Yes. Thank you @skirpichev for the quick fix! |
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…onGH-116302) pythongh-108562: partial reversion of pr114751 Reverts -fstrict-overflow for libmpdec
MemberAuthor
skirpichev commented Mar 5, 2024
Thanks. Sorry for a breakage. Next time I will suggest running more extended tests. |
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…onGH-116302) pythongh-108562: partial reversion of pr114751 Reverts -fstrict-overflow for libmpdec
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…onGH-116302) pythongh-108562: partial reversion of pr114751 Reverts -fstrict-overflow for libmpdec
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts -fstrict-overflow for libmpdec, added in #114751.