Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-89083: add support for UUID version 6 (RFC 9562) #120650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
picnixz commented Jun 17, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
merwok commented Jun 28, 2024
I am puzzled by the PR title change – can you explain? |
picnixz commented Jun 28, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Oh yes, after we discussed the v7 implementation, I preferred splitting the PR into 3 with one PR for each version. The |
merwok commented Jun 28, 2024
«Reference implementation» makes me think that this code is in support or a spec, and maybe not best-written or optimized for production. If this is not the case, just «implementation» or «support» like before has the right connotations 🙂 |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
picnixz commented Feb 22, 2025
Ideally, I'd like to wait for @hugovk's review as well (for both UUIDv6 and v7 as he also reviewed UUIDv8) |
Uh oh!
There was an error while loading. Please reload this page.
picnixz commented Feb 23, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I'll hold the merge until we decide on #130461 so that I don't have introduce conflicts in the doc branch. EDIT: We decided to remove the |
hugovk commented Feb 25, 2025
picnixz commented Feb 25, 2025
@hugovk I'm not sure why the PR is still marked with an "unresolved review". Is it a bot issue? (maybe re-approving the PR would work?) |
hugovk commented Feb 25, 2025
Yeah, looks like the draft->ready transition triggers the bot to add the ![]() And the CI check is:
https://github.com/python/cpython/actions/runs/13521458821/job/37782590646?pr=120650 I'll re-approve. |
picnixz commented Feb 25, 2025
I'll merge both UUIDv6 and v7 (#121119) by the end of the week, so that other core devs may have a look if they want. I'll also prepare a nice commit message. It's great we managed to land those before the last alpha. Hopefully it will stay during the beta and rc phases as well! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
990ad27 into python:mainUh oh!
There was an error while loading. Please reload this page.
picnixz commented Mar 2, 2025
Thank you all for the reviews and the patience! |
hugovk commented Mar 2, 2025
Thank you for the PRs and your patience! 🚀 :) |

In light of the discussion in #89083, I decided to remove the previous commits on version 7 and 8 and restrict this specific PR to version 6 only. The previous post can be found in the history of this message.
For version 7, please discuss it on #121119.
For version 8, please discuss it on #123224.
📚 Documentation preview 📚: https://cpython-previews--120650.org.readthedocs.build/