Skip to content

gh-120780: Show attribute name for LOAD_SPECIAL in dis output#120781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 3 commits into from
Jun 20, 2024
Merged

gh-120780: Show attribute name for LOAD_SPECIAL in dis output #120781

JelleZijlstra merged 3 commits into from
Jun 20, 2024

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented Jun 20, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jun 20, 2024
Closed
iritkatriel
iritkatriel reviewed Jun 20, 2024
View reviewed changes
iritkatriel
iritkatriel reviewed Jun 20, 2024
View reviewed changes
Lib/dis.py Outdated
else:
argrepr = repr(obj)
elif deop == LOAD_SPECIAL:
argrepr = get_special_method_names()[arg]
Copy link
Member

@iritkatrieliritkatrielJun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates the list every time. With the intrinsic descs we cache it in opcode.py.

Copy link
MemberAuthor

@JelleZijlstraJelleZijlstraJun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixed

@JelleZijlstraJelleZijlstra merged commit e8e151d into python:mainJun 20, 2024
@JelleZijlstraJelleZijlstra deleted the loadspecial branch June 20, 2024 14:07
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@JelleZijlstra@mrahtz
pythongh-120780: Show attribute name for LOAD_SPECIAL in dis output (p…
15c3238
…ython#120781)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@JelleZijlstra@noahbkim
pythongh-120780: Show attribute name for LOAD_SPECIAL in dis output (p…
76eba1f
…ython#120781)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@JelleZijlstra@estyxx
pythongh-120780: Show attribute name for LOAD_SPECIAL in dis output (p…
ae5cdb3
…ython#120781)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra@iritkatriel