gh-122247: Move instruction instrumentation sanity check after tracing check#122251
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gaogaotiantian added skip news awaiting core review and removed awaiting core review labels 
Member
encukou commented Aug 2, 2024
What's a good way to learn about the invariants attached to the internal fields like The patch looks good to me, but I don't feel qualified to review it. |
MemberAuthor
gaogaotiantian commented Aug 7, 2024
Unfortunately a lot of the instrumentation related internal fields are undocumented - I basically read the source code to understand those. |
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
…tracing check (pythonGH-122251) (cherry picked from commit 57d7c3e) Co-authored-by: Tian Gao <[email protected]>
GH-122812 is a backport of this pull request to the 3.13 branch. |
encukou pushed a commit that referenced this pull request Aug 16, 2024
… tracing check (GH-122251) (GH-122812) (cherry picked from commit 57d7c3e) Co-authored-by: Tian Gao <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to #117133, code objects are not always up to date. We do not instrument them if we are tracing - because no events will be generated anyway. Therefore, we should check
tstate->tracingfirst for instruction instrumentation, and do the sanity check only when an event is about to be generated.News is skipped because it's an assertion move. No actual behavior is changed to the end user.