[3.13] gh-122247: Move instruction instrumentation sanity check after tracing check (GH-122251)#122812
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…tracing check (pythonGH-122251) (cherry picked from commit 57d7c3e) Co-authored-by: Tian Gao <[email protected]>
This was referenced Aug 8, 2024
Member
gaogaotiantian commented Aug 8, 2024
@markshannon I think because 3.13 is in rc now I should ask for approval even for backport PR |
encukou approved these changes Aug 16, 2024
Member
encukou left a comment
encukou left a comment There was a problem hiding this comment.
This is a straightforward backport of an approved PR. The added test fails now and the PR fixes it. It only touches assert and so it should have no effect on production code.
IMO, it should go in 3.13rc2.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 57d7c3e)
Co-authored-by: Tian Gao [email protected]