gh-86009: Fix solaris detection in _USE_CP_SENDFILE check#124289
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Eclips4 approved these changes Sep 22, 2024
AA-Turner changed the title _USE_CP_SENDFILE check_USE_CP_SENDFILE check
Member
AA-Turner commented Sep 23, 2024
@ambv is there any way to re-run just the CLA check without wasting a full CI run? I suspect this PR was caught by the recent database error. A |
Member
encukou commented Sep 24, 2024
No point in spending human time on that workaround, I think ;) |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am sorry, when rebasing my changes two days ago (PR #23893), I accidentally used 'solaris' rather than 'sunos' string in
sys.platform.startswithcheck for_USE_CP_SENDFILE.This simple PR fixes it (and this is re-tested with our internal buildbots).