bpo-41843: Reenable use of sendfile in shutil module on Solaris#23893
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR is stale because it has been open for 30 days with no activity. |
ContributorAuthor
kulikjak commented Jan 22, 2021
No activity, but still relevant... |
github-actionsbot removed the stale This PR is stale because it has been open for 30 days with no activity. |
ContributorAuthor
kulikjak commented Feb 23, 2021
This is still relevant. |
github-actionsbot removed the stale 
kulikjakforce-pushed the reenable-Solaris-sendfile branch from c0eff8f to b9b0797CompareContributorAuthor
kulikjak commented May 21, 2021
I rebased my changes onto changes introduced with #26024. |
FFY00 approved these changes May 21, 2021
Doc/library/shutil.rst Outdated
| .. versionchanged:: 3.8 | ||
| .. versionchanged:: 3.10 |
ContributorAuthor
There was a problem hiding this comment.
Ah yes, it's fixed now. Thanks.
kulikjakforce-pushed the reenable-Solaris-sendfile branch 2 times, most recently from 4f658dd to 5aee88aCompare
kulikjak added a commit to kulikjak/cpython that referenced this pull request Mar 20, 2023
arhadthedev added the stdlib 
Member
@giampaolo (as an shutil expert), @jcea (as a Solaris platform expert) |
kulikjak added a commit to kulikjak/cpython that referenced this pull request May 9, 2023
kulikjakforce-pushed the reenable-Solaris-sendfile branch from 46b9f2b to 1a3a1b4Compare
kulikjakforce-pushed the reenable-Solaris-sendfile branch from 1a3a1b4 to 944c17eCompare
kulikjak commented Sep 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
kulikjak commented Sep 20, 2024
I am sorry, I just realized that when rebasing my changes, I accidentally used 'solaris' rather than 'sunos' in the platform check. I created #124289 to fix this. |
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the integration of #22040,
os.sendfilenow works as expected and hence its use inshutilas a fast-copy syscall for file copies should be reenabled (it was disabled with #13675 due to small differences in offset handling and return values).I am not sure what exactly to write into
shutil.rstas if backported, theversionchanged:: 3.10part would not be correct, but it wasn't there from the beginning of 3.9 either, and it seems that micro versions are not specified there (or maybe this is not a change that should be backported) ??Also, I enabled the Solaris here explicitly, but maybe reverting the #13675 (and by doing so enabling the use of
sendfileon every system that has it available, which might actually be just Linux and Solaris...) is a better option.https://bugs.python.org/issue41843