Skip to content

gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash#125218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdboom wants to merge 4 commits into from
Closed

gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash #125218

mdboom wants to merge 4 commits into from

Conversation

@mdboom
Copy link
Contributor

@mdboommdboom commented Oct 9, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Oct 9, 2024
Closed
@mdboommdboom changed the title gh-125217: Turn off optimization are _PyEval_EvalFrameDefault to avoid MSVC crashgh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crashOct 9, 2024
@mdboommdboom marked this pull request as draft October 10, 2024 15:47
@mdboom
Copy link
ContributorAuthor

mdboom commented Oct 11, 2024

Closing is this does not resolve the issue.

@mdboommdboom closed this Oct 11, 2024
@neonene
Copy link
Contributor

neonene commented Oct 14, 2024

Have you already tried _Py_JIT (underscored)? I have an alternative, but I prefer this.

@mdboom
Copy link
ContributorAuthor

mdboom commented Oct 14, 2024

Have you already tried _Py_JIT (underscored)? I have an alternative, but I prefer this.

Thanks, @neonene. Indeed, that was just a typo on my part and correcting it does work around the compiler crash. Github wouldn't let me re-open this but I have a new PR here: #125477

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski will be requested when the pull request is marked ready for reviewsavannahostrowski is a code owner

@diegorussodiegorussoAwaiting requested review from diegorussodiegorusso will be requested when the pull request is marked ready for reviewdiegorusso is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti will be requested when the pull request is marked ready for reviewezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk will be requested when the pull request is marked ready for reviewhugovk is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner

@webknjazwebknjazAwaiting requested review from webknjazwebknjaz will be requested when the pull request is marked ready for reviewwebknjaz is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdboom@neonene