gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash#125477
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mdboom commented Oct 14, 2024
| ./python -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3 | ||
| jit: | ||
| name: ${{matrix.target }} (${{matrix.debug && 'Debug' || 'Release'}}) | ||
| needs: interpreter |
ContributorAuthor
There was a problem hiding this comment.
Removing the requirement on the Tier 2 interpreter pass here, since it seems to be failing consistently on test.test_asyncio.test_taskgroups, and I'm not sure that's relevant to this PR.
ContributorAuthor
There was a problem hiding this comment.
Ah, thanks. We won't merge these changes, then, but it's useful for now to illustrate that the fix here works.
… to avoid MSVC crash
mdboomforce-pushed the disable-interpreter-optimizations-when-jit-enabled branch from bfcfe72 to 8340829Comparemdboom commented Oct 15, 2024
Python/jit.c Outdated
| #include"pycore_sliceobject.h" | ||
| #include"pycore_jit.h" | ||
ContributorAuthor
There was a problem hiding this comment.
This is to trigger the JIT CI, but I can remove this commit before merging.
brandtbucher approved these changes Oct 15, 2024
mdboomforce-pushed the disable-interpreter-optimizations-when-jit-enabled branch from a55510c to 8340829Compareebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
… to avoid MSVC crash (python#125477)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.