gh-126742: allow to use non-UTF8 exception messages#126746

picnixz · 2024-11-12T14:21:46Z

Issue: Allow to set non-UTF8 exception messages #126742

Python/errors.c

ZeroIntensity · 2024-11-12T14:31:16Z

Technically, since this is a bugfix, let's wait until #126555 has landed before we merge this, and then address all the uses of dlerror() in this PR.

picnixz · 2024-11-12T14:34:13Z

then address all the uses of dlerror() in this PR.

I actually thought of doing it two PRs. Technically, this specific PR can be merged without waiting for the other and then you can use this interface in the other (rather the other way around).

ZeroIntensity · 2024-11-12T14:52:20Z

Eh, I would rather not. Let's not overwhelm someone with thread states and the private API on their first PR :)

ZeroIntensity · 2024-11-13T11:53:04Z

I've removed backport labels, per what Petr said in the issue. I think he's right--let's just focus on main with this.

encukou · 2024-11-15T13:17:46Z

Hmm, just had an idea: if we add a “char* in locale encoding” format to PyUnicode_FromFormat, it'll be possible to use it with PyErr_Format -- but also for non-error messages.

ZeroIntensity · 2024-11-15T13:28:56Z

I like that idea! But we're exposing this as a public API--how often might users need this? (I've never needed to mess with locale in any of my C API usage, but to be fair I'm typically not calling APIs that return strings.)

picnixz · 2024-11-15T13:42:16Z

Hmm, just had an idea: if we add a “char* in locale encoding” format to

I'm not very fond of adding a case to additionally check when there's not a lot of use cases (unless proven otherwise). It shouldn't affect performances much (but this needs verification) but this would complicate an already complicate function I think (and people need to remember this new format as well).

ZeroIntensity · 2024-11-15T13:59:32Z

No no, I don't think he meant a variation of PyUnicode_FromFormat that takes a locale, he meant a format value %whatever that automatically calls PyUnicode_DecodeLocale or something like that.

picnixz · 2024-11-15T14:03:29Z

No no, I don't think he meant a variation of PyUnicode_FromFormat that takes a locale, he meant a format value %whatever that automatically calls PyUnicode_DecodeLocale or something like that.

And I understood. I don't think a new code should be added unless there is a real need.

ZeroIntensity · 2024-11-15T14:13:48Z

And I understood.

Ah! I couldn't tell, sorry.

A code search for PyUnicode_DecodeLocale is showing not too much real world usage--maybe that's a bad thing? Depending on how common it is for a non-UTF8 locale to break things, maybe it would be a good idea to add a format character just so people start handling it.

encukou · 2024-11-19T12:09:21Z

It could also show that we're mainly handling errors from the OS at one point -- the OSError constructor. That would be a good thing :)

Anyway, for this PR: @picnixz, do you want to add calls to the new helper(s)?

ZeroIntensity · 2024-11-19T12:29:06Z

FWIW, Bénédikt is on vacation right now. I don't think he'll be able to implement anything until next week.

vstinner

I don't see the purpose of these internal functions since they are now used. This PR only adds dead code. I would prefer to see how these functions are used.

If only dlerror() uses it, why not using code using dlerror()?

Include/internal/pycore_pyerrors.h

miss-islington-app · 2024-12-17T11:22:12Z

Thanks @picnixz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2024-12-17T11:22:15Z

Sorry, @picnixz and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7303f06846b69016a075bca7ad7c6055f29ad024 3.12

…r messages (pythonGH-126746) - Add a helper to set an error from locale-encoded `char*` - Use the helper for gdbm & dlerror messages (cherry picked from commit 7303f06) Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Victor Stinner <[email protected]>

bedevere-app · 2024-12-17T11:22:29Z

GH-128023 is a backport of this pull request to the 3.13 branch.

serhiy-storchaka · 2024-12-17T11:22:43Z

This is a bug fix. It should be backported.

picnixz · 2024-12-17T11:33:50Z

Ah! I think we should also have a NEWS entry. I'll add one. Sorry for forgetting about it :(

picnixz · 2024-12-17T11:34:49Z

Concerning the failure on 3.12 backport it's because we did not backported the PR on dlerror() usages yet. I've opened a PR for that #127764

…or messages (GH-126746) (GH-128023) - Add a helper to set an error from locale-encoded `char*` - Use the helper for gdbm & dlerror messages (cherry picked from commit 7303f06) Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Victor Stinner <[email protected]>

miss-islington-app · 2024-12-17T11:55:20Z

Thanks @picnixz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2024-12-17T11:55:23Z

Sorry, @picnixz and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7303f06846b69016a075bca7ad7c6055f29ad024 3.12

picnixz · 2024-12-17T11:55:43Z

Grrr. I thought that the conflicts would be easily solved but apparently not. I'll do the backport manually.

…r messages (pythonGH-126746) - Add a helper to set an error from locale-encoded `char*` - Use the helper for gdbm & dlerror messages Co-authored-by: Victor Stinner <[email protected]>

bedevere-app · 2024-12-17T12:07:41Z

GH-128027 is a backport of this pull request to the 3.12 branch.

…or messages (GH-126746) (GH-128027) - Add a helper to set an error from locale-encoded `char*` - Use the helper for gdbm & dlerror messages Co-authored-by: Victor Stinner <[email protected]>

bedevere-bot · 2024-12-17T15:42:36Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.x has failed when building commit 7303f06.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/559/builds/5438) and take a look at the build logs.
Check if the failure is related to this commit (7303f06) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/559/builds/5438

Failed tests:

test_ctypes

Failed subtests:

test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsymself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'

picnixz · 2024-12-17T16:05:02Z

Ok, so I didn't expect that on some archs, the error message would be different...

bedevere-bot · 2024-12-17T17:05:53Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO 3.x has failed when building commit 7303f06.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/361/builds/5642) and take a look at the build logs.
Check if the failure is related to this commit (7303f06) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/361/builds/5642

Failed tests:

test_ctypes

Failed subtests:

test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsymself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'

vstinner · 2024-12-17T17:08:48Z

Tests are failing on PPC64LE RHEL8 LTO 3.x:

AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'

picnixz · 2024-12-17T17:17:20Z

I've opened #128034 for this but Serhiy suggested removing the filename check as well.

bedevere-bot · 2024-12-17T17:35:12Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.13 has failed when building commit fe08cdf.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1430/builds/360) and take a look at the build logs.
Check if the failure is related to this commit (fe08cdf) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1430/builds/360

Failed tests:

test_ctypes

Failed subtests:

test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsymself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'

bedevere-bot · 2024-12-17T18:38:46Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO + PGO 3.13 has failed when building commit fe08cdf.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1444/builds/374) and take a look at the build logs.
Check if the failure is related to this commit (fe08cdf) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1444/builds/374

Failed tests:

test_ctypes

Failed subtests:

test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsymself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'

bedevere-bot · 2024-12-17T19:03:44Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO 3.13 has failed when building commit fe08cdf.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1412/builds/375) and take a look at the build logs.
Check if the failure is related to this commit (fe08cdf) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1412/builds/375

Failed tests:

test_ctypes

Failed subtests:

test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.lto/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsymself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'

bedevere-bot · 2024-12-17T19:46:34Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 Refleaks 3.13 has failed when building commit fe08cdf.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1407/builds/317) and take a look at the build logs.
Check if the failure is related to this commit (fe08cdf) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1407/builds/317

Failed tests:

test_ctypes

Failed subtests:

test_localized_error_in_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_in_dll
test_localized_error_from_dll - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_from_dll
test_localized_error_dlsym - test.test_ctypes.test_dlerror.TestLocalization.test_localized_error_dlsym

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_ctypes/test_dlerror.py", line 153, in test_localized_error_in_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_ctypes/test_dlerror.py", line 144, in test_localized_error_from_dllself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist' Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/contextlib.py", line 85, in innerreturn func(*args, **kwds) File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_ctypes/test_dlerror.py", line 179, in test_localized_error_dlsymself.assertIn(self.libc_filename, str(cm.exception)) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'libc.so.6' not found in '/lib64/glibc-hwcaps/power9/libc-2.28.so: undefined symbol: this_name_does_not_exist'

…r messages (pythonGH-126746) - Add a helper to set an error from locale-encoded `char*` - Use the helper for gdbm & dlerror messages Co-authored-by: Victor Stinner <[email protected]>

allow to use translated exception messages
24eb521

bedevere-appbot added the awaiting review label Nov 12, 2024

bedevere-appbot mentioned this pull request Nov 12, 2024
Allow to set non-UTF8 exception messages #126742
Closed

picnixz added the skip news label Nov 12, 2024

picnixz changed the title ~~gh-126742: allow to use translated exception messages~~gh-126742: allow to use non-UTF8 exception messagesNov 12, 2024

picnixz requested review from ZeroIntensity and encukou November 12, 2024 14:25

ZeroIntensity reviewed Nov 12, 2024
View reviewed changes

Python/errors.c Outdated Show resolvedHide resolved
Python/errors.c Outdated Show resolvedHide resolved

ZeroIntensity added DO-NOT-MERGE needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 12, 2024

Use 'surrogateescape' handler instead of 'strict' handler.
4c0f85b

ZeroIntensity removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes DO-NOT-MERGE labels Nov 13, 2024

vstinner reviewed Nov 19, 2024
View reviewed changes

Include/internal/pycore_pyerrors.h Outdated Show resolvedHide resolved

encukou marked this pull request as draft November 20, 2024 09:46

bedevere-appbot removed the awaiting review label Nov 20, 2024

miss-islington-appbot assigned encukou Dec 17, 2024

bedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Dec 17, 2024

picnixz deleted the fix/locale-set-object-exception-126742 branch December 17, 2024 11:44

picnixz added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Dec 17, 2024

bedevere-appbot removed the needs backport to 3.12 only security fixes label Dec 17, 2024

Uh oh!

gh-126742: allow to use non-UTF8 exception messages#126746

gh-126742: allow to use non-UTF8 exception messages #126746

Uh oh!

Conversation

picnixz commented Nov 12, 2024• edited by bedevere-app botLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZeroIntensity commented Nov 12, 2024

Uh oh!

picnixz commented Nov 12, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZeroIntensity commented Nov 12, 2024

Uh oh!

ZeroIntensity commented Nov 13, 2024

Uh oh!

encukou commented Nov 15, 2024

Uh oh!

ZeroIntensity commented Nov 15, 2024

Uh oh!

picnixz commented Nov 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZeroIntensity commented Nov 15, 2024

Uh oh!

picnixz commented Nov 15, 2024

Uh oh!

ZeroIntensity commented Nov 15, 2024

Uh oh!

encukou commented Nov 19, 2024

Uh oh!

ZeroIntensity commented Nov 19, 2024

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-appbot commented Dec 17, 2024

Uh oh!

miss-islington-appbot commented Dec 17, 2024

Uh oh!

bedevere-appbot commented Dec 17, 2024

Uh oh!

serhiy-storchaka commented Dec 17, 2024

Uh oh!

picnixz commented Dec 17, 2024

Uh oh!

picnixz commented Dec 17, 2024

Uh oh!

miss-islington-appbot commented Dec 17, 2024

Uh oh!

miss-islington-appbot commented Dec 17, 2024

Uh oh!

picnixz commented Dec 17, 2024

Uh oh!

bedevere-appbot commented Dec 17, 2024

Uh oh!

bedevere-bot commented Dec 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

picnixz commented Dec 17, 2024

Uh oh!

bedevere-bot commented Dec 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

vstinner commented Dec 17, 2024

Uh oh!

picnixz commented Dec 17, 2024

Uh oh!

bedevere-bot commented Dec 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

picnixz commented Nov 12, 2024•
edited by bedevere-app bot
Loading

picnixz commented Nov 12, 2024•
edited
Loading

picnixz commented Nov 15, 2024•
edited
Loading