Skip to content

gh-126742: avoid checking for library filename in dlerror() error messages#128034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Dec 18, 2024
Merged

gh-126742: avoid checking for library filename in dlerror() error messages #128034

vstinner merged 2 commits into from
Dec 18, 2024

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Dec 17, 2024•
edited by bedevere-app bot
Loading

I will run this one with all buildbots.

@bedevere-appbedevere-appbot mentioned this pull request Dec 17, 2024
Closed
@bedevere-appbedevere-appbot added tests Tests in the Lib/test dir awaiting review labels Dec 17, 2024
@picnixzpicnixz added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting review labels Dec 17, 2024
@bedevere-bot
Copy link

bedevere-bot commented Dec 17, 2024

🤖 New build scheduled with the buildbot fleet by @picnixz for commit d062bd7 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 17, 2024
serhiy-storchaka
serhiy-storchaka reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this check at all?

@picnixz
Copy link
MemberAuthor

picnixz commented Dec 17, 2024

Do we need this check at all?

I wanted to at least check that the filename would be present but considering that the maintenance could be annoying, I'm ok with dropping it. Technically, catching the exception should be sufficient (namely, not catching UnicodeDecodeError) right?

@picnixzpicnixz mentioned this pull request Dec 17, 2024
Merged
vstinner
vstinner reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, just remove the filename check.

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Dec 17, 2024

Agree.

@picnixzpicnixz changed the title gh-126742: fix tests on some buildbotsgh-126742: avoid checking for library filename in dlerror() error messagesDec 17, 2024
@serhiy-storchakaserhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 17, 2024
@bedevere-bot
Copy link

bedevere-bot commented Dec 17, 2024

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit a1c32ce 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 17, 2024
@vstinner
Copy link
Member

vstinner commented Dec 18, 2024

Two buildbot workers failed:

buildbot/ARM64 MacOS M1 NoGIL PR — Build done.
buildbot/ARM64 MacOS M1 Refleaks NoGIL PR — Build done.

multiprocessing tests failed: it's unrelated.

@vstinnervstinner merged commit 335e24f into python:mainDec 18, 2024
113 of 115 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Dec 18, 2024

Thanks @picnixz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 18, 2024
@picnixz@miss-islington
pythongh-126742: Avoid checking for library filename in test_ctypes (p…
3deb317
…ythonGH-128034) Avoid checking for library filename in `dlerror()` error messages of test_ctypes. (cherry picked from commit 335e24f) Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 18, 2024
@picnixz@miss-islington
pythongh-126742: Avoid checking for library filename in test_ctypes (p…
ededa43
…ythonGH-128034) Avoid checking for library filename in `dlerror()` error messages of test_ctypes. (cherry picked from commit 335e24f) Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Dec 18, 2024

GH-128056 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Dec 18, 2024
@bedevere-app
Copy link

bedevere-appbot commented Dec 18, 2024

GH-128057 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Dec 18, 2024
@picnixzpicnixz deleted the patch/localization/126742 branch December 18, 2024 08:28
vstinner pushed a commit that referenced this pull request Dec 18, 2024
@miss-islington@picnixz
[3.12]gh-126742: Avoid checking for library filename in test_ctypes (G…
6ffa564
…H-128034) (#128057) gh-126742: Avoid checking for library filename in test_ctypes (GH-128034) Avoid checking for library filename in `dlerror()` error messages of test_ctypes. (cherry picked from commit 335e24f) Co-authored-by: Bénédikt Tran <[email protected]>
vstinner pushed a commit that referenced this pull request Dec 18, 2024
@miss-islington@picnixz
[3.13]gh-126742: Avoid checking for library filename in test_ctypes (G…
2ff3e95
…H-128034) (#128056) gh-126742: Avoid checking for library filename in test_ctypes (GH-128034) Avoid checking for library filename in `dlerror()` error messages of test_ctypes. (cherry picked from commit 335e24f) Co-authored-by: Bénédikt Tran <[email protected]>
@encukouencukou mentioned this pull request Dec 18, 2024
Merged
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz@srinivasreddy
pythongh-126742: Avoid checking for library filename in test_ctypes (p…
8d5f556
…ython#128034) Avoid checking for library filename in `dlerror()` error messages of test_ctypes.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@picnixz@bedevere-bot@serhiy-storchaka@vstinner