Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-128446: Skip Windows CI for Unix build system changes#128450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
srinivasreddy commented Jan 3, 2025 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
erlend-aasland commented Jan 6, 2025
Let's put this into draft while you test out the change. Mark it as ready for review when you've got it working. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
AA-Turner commented Feb 11, 2025
Let's proceed as-is, we can iterate later. I'll wait to merge until the 3.14a5 commit is pushed. |
b05fa90 into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to |
Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to |
AA-Turner commented Feb 12, 2025
We didn't backport #129627, hence failing backports. Are backports worth it here? A |
bedevere-bot commented Feb 12, 2025
|
hugovk commented Feb 12, 2025
I think so, it would be good to keep (at least) the bugfix branches in sync, to make future backports and general maintenance easier. |
Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to |
…nGH-128450) (cherry picked from commit b05fa90) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com> Authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
GH-130434 is a backport of this pull request to the 3.13 branch. |
…pythonGH-128450) (cherry picked from commit b05fa90) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com> Authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
GH-130435 is a backport of this pull request to the 3.12 branch. |
…28450) (#130435) (cherry picked from commit b05fa90) Authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com> Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
…28450) (#130434) gh-128446: Skip Windows CI for Unix build system changes (GH-128450) (cherry picked from commit b05fa90) Authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com> Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
configure/Makefilechanges #128446