Skip to content

Conversation

@srinivasreddy
Copy link
Contributor

@srinivasreddysrinivasreddy commented Jan 3, 2025

@srinivasreddy

This comment was marked as outdated.

@erlend-aasland

This comment was marked as outdated.

@erlend-aasland
Copy link
Contributor

Let's put this into draft while you test out the change. Mark it as ready for review when you've got it working.

@erlend-aaslanderlend-aasland marked this pull request as draft January 6, 2025 08:29
@srinivasreddy

This comment was marked as outdated.

@srinivasreddy

This comment was marked as outdated.

@srinivasreddysrinivasreddy marked this pull request as ready for review January 6, 2025 13:50
@srinivasreddy

This comment was marked as outdated.

@hugovk

This comment was marked as outdated.

@srinivasreddy

This comment was marked as outdated.

@hugovk

This comment was marked as outdated.

@srinivasreddy

This comment was marked as outdated.

@hugovk

This comment was marked as outdated.

@AA-Turner
Copy link
Member

Let's proceed as-is, we can iterate later. I'll wait to merge until the 3.14a5 commit is pushed.

@AA-TurnerAA-Turner changed the title gh-128446: Skip Windows CI for configure/Makefile changesgh-128446: Skip Windows CI for Unix build system changesFeb 11, 2025
@AA-TurnerAA-Turner merged commit b05fa90 into python:mainFeb 12, 2025
48 of 49 checks passed
@miss-islington-app
Copy link

Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b05fa90b21dd01bb836285cdd41920320b09e681 3.13 

@miss-islington-app
Copy link

Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b05fa90b21dd01bb836285cdd41920320b09e681 3.12 

@AA-Turner
Copy link
Member

We didn't backport #129627, hence failing backports. Are backports worth it here?

A

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.x has failed when building commit b05fa90.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1610/builds/837) and take a look at the build logs.
  4. Check if the failure is related to this commit (b05fa90) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1610/builds/837

Failed tests:

  • test_free_threading

Failed subtests:

  • test_free_reference - test.test_concurrent_futures.test_thread_pool.ThreadPoolExecutorTest.test_free_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 132, in test_free_referenceself.assertIsNone(wr()) ~~~~~~~~~~~~~~~~~^^^^^^AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20006220090> is not None

@hugovk
Copy link
Member

We didn't backport #129627, hence failing backports. Are backports worth it here?

A

I think so, it would be good to keep (at least) the bugfix branches in sync, to make future backports and general maintenance easier.

@AA-TurnerAA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes needs backport to 3.12 only security fixes labels Feb 22, 2025
@miss-islington-app
Copy link

Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @srinivasreddy for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @srinivasreddy and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b05fa90b21dd01bb836285cdd41920320b09e681 3.12 

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2025
…nGH-128450) (cherry picked from commit b05fa90) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com> Authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-130434 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Feb 22, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 22, 2025
…pythonGH-128450) (cherry picked from commit b05fa90) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com> Authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-130435 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Feb 22, 2025
AA-Turner added a commit that referenced this pull request Feb 22, 2025
…28450) (#130435) (cherry picked from commit b05fa90) Authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com> Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Feb 22, 2025
…28450) (#130434) gh-128446: Skip Windows CI for Unix build system changes (GH-128450) (cherry picked from commit b05fa90) Authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com> Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
@srinivasreddysrinivasreddy deleted the gh-128446 branch March 25, 2025 08:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip Windows CI for configure/Makefile changes

5 participants

@srinivasreddy@erlend-aasland@hugovk@AA-Turner@bedevere-bot