Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Mar 25, 2025

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovkhugovk merged commit 7d9442f into python:mainMar 25, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2025
(cherry picked from commit 7d9442f) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-131705 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Mar 25, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2025
(cherry picked from commit 7d9442f) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-131706 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Mar 25, 2025
@hugovk
Copy link
Member

The Windows build is running on main now:

image

https://github.com/python/cpython/actions/runs/14053641267/job/39348432127

Should it also run Windows MSI?

@AA-TurnerAA-Turner deleted the win-test branch March 25, 2025 20:19
@AA-Turner
Copy link
MemberAuthor

Should it also run Windows MSI?

Previously this wasn't run for each commit. I'm cautious about adding more jobs to CI, due to limited resources, and it might be that the MSI tests are run by the buildbots.

A

hugovk pushed a commit that referenced this pull request Mar 28, 2025
…31705) gh-128446: Run Windows CI tests on each commit (GH-131702) (cherry picked from commit 7d9442f) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Mar 28, 2025
…31706) gh-128446: Run Windows CI tests on each commit (GH-131702) (cherry picked from commit 7d9442f) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AA-Turner@hugovk@zanieb