Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
Enable Windows on Arm GitHub runners#131559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
diegorusso commented Mar 21, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
77d3e04 to c3f95a3Comparebrandtbucher commented Mar 21, 2025
Exciting! I think the JIT failure should be fixed on |
brandtbucher commented Mar 21, 2025
...looks like JIT builds were broken again. |
Uh oh!
There was an error while loading. Please reload this page.
.github/workflows/build.yml Outdated
| - true | ||
| include: | ||
| - os: windows-latest # FIXME(diegorusso): change to os: windows-aarch64 | ||
| - os: windows-aarch64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. At the moment these are available on selected projects for now. I'm not sure when they will be in GA. I will ask and report back.
I'll add something to skip the aarch64 on forks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check if you have Windows runners available on forks without my patch? See here: https://github.com/diegorusso/cpython/actions/runs/14119011738
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also CIFuzz are skipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I do have Windows runners on forks without this patch, here's main and a branch from main:
- https://github.com/hugovk/cpython/actions/runs/14126514909
- https://github.com/hugovk/cpython/actions/runs/14126621995
Note #131702 was merged 3 days ago to fix a Windows skip when running on main, and I don't think we have that here yet? Let's first update this PR from main and re-check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah maybe I need to rebase the branch then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look now.
Uh oh!
There was an error while loading. Please reload this page.
152c36b to 3388831Compare


I had to put some if conditions in different steps because these runners are not generally available hence skipping checks on forks.