Skip to content

gh-128550: TaskGroup: cancel tasks added to set after aborting#128551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graingert wants to merge 13 commits into from
Closed

gh-128550: TaskGroup: cancel tasks added to set after aborting #128551

graingert wants to merge 13 commits into from

Conversation

@graingert
Copy link
Contributor

@graingertgraingert commented Jan 6, 2025•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jan 6, 2025
Closed
@graingert
Copy link
ContributorAuthor

graingert commented Jan 6, 2025

I'm refactoring the tests to run the TaskGroup tests on eager and lazy tasks and have found another issue. I'm afk at the moment and will fix that one shortly too

@graingert
Copy link
ContributorAuthor

graingert commented Jan 6, 2025

Ok I have the other issue here: #128553

graingert
graingert commented Jan 6, 2025
View reviewed changes
graingert
graingert commented Jan 6, 2025
View reviewed changes
graingert
graingert commented Jan 6, 2025
View reviewed changes
@graingertgraingert marked this pull request as ready for review January 6, 2025 18:58
ZeroIntensity
ZeroIntensity reviewed Jan 6, 2025
View reviewed changes
graingert
graingert commented Jan 6, 2025
View reviewed changes
graingert
graingert commented Jan 6, 2025
View reviewed changes
graingert
graingert commented Jan 6, 2025
View reviewed changes
@graingertgraingert deleted the fix-taskgroup-eager branch January 20, 2025 17:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

No one assigned

Labels

awaiting core reviewtopic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graingert@ZeroIntensity@AlexWaygood