gh-128552: fix refcycles in eager task creation#128553

graingert · 2025-01-06T18:17:42Z

Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552

Lib/asyncio/base_events.py

Lib/asyncio/taskgroups.py

…5-01-06-18-41-08.gh-issue-128552.fV-f8j.rst

Misc/NEWS.d/next/Library/2025-01-06-18-41-08.gh-issue-128552.fV-f8j.rst

…V-f8j.rst

Lib/asyncio/base_events.py

Lib/asyncio/taskgroups.py

kumaraditya303 · 2025-01-07T07:13:54Z

if possible can you add a test which uses weakref to check for refcycle

Lib/asyncio/base_events.py

kumaraditya303 · 2025-01-07T11:14:09Z

Lib/test/test_asyncio/test_taskgroups.py


 fromtest.test_asyncio.utilsimportawait_without_task

-# To prevent a warning "test altered the execution environment"


I know this isn't needed as you have changed it to use asyncio.EventLoop but let's keep it for now, it is easy to make a mistake on altering policy and is a pain to fix in CI if it happens without this.

Lib/test/test_asyncio/test_taskgroups.py

kumaraditya303 · 2025-01-07T11:31:10Z

Lib/test/test_asyncio/test_taskgroups.py

+
+self.assertIsNone(task_wr())
+self.assertIsInstance(exc, _Done)
+self.assertListEqual(gc.get_referrers(exc), no_other_refs())


I think it was later changed that coro doesn't hold ref to locals, no_other_refs should not be necessary here.

Ah its not merged yet #125640

kumaraditya303

Thanks

miss-islington-app · 2025-01-07T11:45:48Z

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2025-01-07T11:45:51Z

Sorry, @graingert and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 61b9811ac6843e22b5896ef96030d421b79cd892 3.13

miss-islington-app · 2025-01-07T11:45:55Z

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2025-01-07T11:45:58Z

Sorry, @graingert and @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 61b9811ac6843e22b5896ef96030d421b79cd892 3.12

bedevere-app · 2025-01-07T12:10:17Z

GH-128585 is a backport of this pull request to the 3.13 branch.

(cherry picked from commit 61b9811)

bedevere-app · 2025-01-07T12:23:13Z

GH-128586 is a backport of this pull request to the 3.12 branch.

…8585) gh-128552: fix refcycles in eager task creation (#128553) (cherry picked from commit 61b9811)

bedevere-app · 2025-01-20T18:00:25Z

GH-128586 is a backport of this pull request to the 3.12 branch.

pythongh-128552: fix refcycles in eager task creation
c82f30b

bedevere-appbot mentioned this pull request Jan 6, 2025
TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552
Closed

graingert commented Jan 6, 2025
View reviewed changes

Lib/asyncio/base_events.py Outdated Show resolvedHide resolved

Update Lib/asyncio/base_events.py
8a4eb56

graingert commented Jan 6, 2025
View reviewed changes

Lib/asyncio/taskgroups.pyShow resolvedHide resolved

Update Lib/asyncio/taskgroups.py
35a38e4

graingert mentioned this pull request Jan 6, 2025
gh-128550: TaskGroup: cancel tasks added to set after aborting #128551
Closed

blurb-itbotand others added 2 commits January 6, 2025 18:41

📜🤖 Added by blurb_it.
afd3053

Rename 2025-01-06-18-41-08.gh-issue-pythongh-128552.fV-f8j.rst to 202…
9700ebf
…5-01-06-18-41-08.gh-issue-128552.fV-f8j.rst

graingert marked this pull request as ready for review January 6, 2025 18:45

graingert requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners January 6, 2025 18:45

bedevere-appbot added the awaiting review label Jan 6, 2025

graingert commented Jan 6, 2025
View reviewed changes

Misc/NEWS.d/next/Library/2025-01-06-18-41-08.gh-issue-128552.fV-f8j.rst Outdated Show resolvedHide resolved

Update Misc/NEWS.d/next/Library/2025-01-06-18-41-08.gh-issue-128552.f…
fe83add
…V-f8j.rst

graingert requested a review from ZeroIntensity January 6, 2025 19:01

Merge branch 'main' into fix-taskgroup-eager-refcycle
a1f76df

ZeroIntensity reviewed Jan 6, 2025
View reviewed changes

Lib/asyncio/base_events.py Outdated Show resolvedHide resolved
Lib/asyncio/taskgroups.py Outdated Show resolvedHide resolved
Lib/asyncio/taskgroups.py Outdated Show resolvedHide resolved

ZeroIntensity added the topic-asyncio label Jan 6, 2025

graingert added 3 commits January 7, 2025 08:06

add a version of the test with weakrefs
7c966d0

Merge branch 'main' into fix-taskgroup-eager-refcycle
89362f5

simplify and comment
cf5cfe3

graingert commented Jan 7, 2025
View reviewed changes

Lib/asyncio/base_events.py Outdated Show resolvedHide resolved

Update Lib/asyncio/base_events.py
18b6ea9

graingert requested a review from ZeroIntensity January 7, 2025 09:01

kumaraditya303 reviewed Jan 7, 2025
View reviewed changes

graingert commented Jan 7, 2025
View reviewed changes

Lib/test/test_asyncio/test_taskgroups.pyShow resolvedHide resolved

restore _set_event_loop_policy(None)
ca71935

graingert commented Jan 7, 2025
View reviewed changes

Lib/test/test_asyncio/test_taskgroups.py Outdated Show resolvedHide resolved

remove type annotations
cc39717

kumaraditya303 self-assigned this Jan 7, 2025

kumaraditya303 reviewed Jan 7, 2025
View reviewed changes

kumaraditya303 approved these changes Jan 7, 2025
View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting review labels Jan 7, 2025

kumaraditya303 enabled auto-merge (squash) January 7, 2025 11:42

kumaraditya303 merged commit 61b9811 into python:mainJan 7, 2025
42 checks passed

bedevere-appbot removed the awaiting merge label Jan 7, 2025

graingert added the needs backport to 3.13 bugs and security fixes label Jan 7, 2025

graingert added the needs backport to 3.12 only security fixes label Jan 7, 2025

graingert deleted the fix-taskgroup-eager-refcycle branch January 7, 2025 11:46

bedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jan 7, 2025

graingert added a commit to graingert/cpython that referenced this pull request Jan 7, 2025
pythongh-128552: fix refcycles in eager task creation (python#128553)
ceaafff
(cherry picked from commit 61b9811)

bedevere-appbot removed the needs backport to 3.12 only security fixes label Jan 7, 2025

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-128552: fix refcycles in eager task creation (python#128553)
c50dfd7

kumaraditya303 pushed a commit that referenced this pull request Jan 8, 2025
[3.13]gh-128552: fix refcycles in eager task creation (#128553) (#12…
1383588
…8585) gh-128552: fix refcycles in eager task creation (#128553) (cherry picked from commit 61b9811)


		fromtest.test_asyncio.utilsimportawait_without_task

		# To prevent a warning "test altered the execution environment"

Uh oh!

gh-128552: fix refcycles in eager task creation#128553

gh-128552: fix refcycles in eager task creation #128553

Uh oh!

Conversation

graingert commented Jan 6, 2025• edited by bedevere-app botLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kumaraditya303 commented Jan 7, 2025

Uh oh!

Uh oh!

kumaraditya303Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kumaraditya303Jan 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kumaraditya303Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

kumaraditya303 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-appbot commented Jan 7, 2025

Uh oh!

miss-islington-appbot commented Jan 7, 2025

Uh oh!

miss-islington-appbot commented Jan 7, 2025

Uh oh!

miss-islington-appbot commented Jan 7, 2025

Uh oh!

bedevere-appbot commented Jan 7, 2025

Uh oh!

bedevere-appbot commented Jan 7, 2025

Uh oh!

bedevere-appbot commented Jan 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

graingert commented Jan 6, 2025•
edited by bedevere-app bot
Loading

kumaraditya303Jan 7, 2025•
edited
Loading