Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings#128726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings #128726
Uh oh!
There was an error while loading. Please reload this page.
Conversation
0788978 to a3b61aaCompare6659cad to 6d7c395Comparee7af412 to 0f2afcdCompare
sobolevn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big +1 from me!
hugovk commented Jan 17, 2025
Let's merge this. @graingert Please could you update the title to reflect the current behaviour of the PR? |
graingert commented Jan 17, 2025
@hugovk ok, I've updated the title |
7807b40 into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @graingert for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…test_socket which still logs warnings (pythonGH-128726) (cherry picked from commit 7807b40) Co-authored-by: Thomas Grainger <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Brett Cannon <[email protected]>
Sorry, @graingert and @hugovk, I could not cleanly backport this to |
GH-128935 is a backport of this pull request to the 3.13 branch. |
bedevere-bot commented Jan 17, 2025
|
sobolevn commented Jan 17, 2025
I think we should revert this change and fix buildbots first. |
…ept for test_socket which still logs warnings (python#128726)" This reverts commit 7807b40.
hugovk commented Jan 17, 2025
Revert PR: #128936. |
bedevere-bot commented Jan 17, 2025
|
…cept for test_socket which still logs warnings (python#128726)" (python#128936) This reverts commit 76856ae.
…test_socket which still logs warnings (python#128726) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Brett Cannon <[email protected]>
…ept for test_socket which still logs warnings (python#128726)" (python#128936)
Uh oh!
There was an error while loading. Please reload this page.