Revert "gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings (#128726)"#128936
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ept for test_socket which still logs warnings (python#128726)" This reverts commit 7807b40.
graingert approved these changes Jan 17, 2025
hugovk merged commit 76856ae into python:main 48 checks passed
Uh oh!
There was an error while loading. Please reload this page.
graingert added a commit to graingert/cpython that referenced this pull request Jan 18, 2025
…cept for test_socket which still logs warnings (python#128726)" (python#128936) This reverts commit 76856ae.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
…ept for test_socket which still logs warnings (python#128726)" (python#128936)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7807b40.
We need to fix the buildbots first: #128726 (comment).