Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-128231: Use runcode() return value for failing early#129488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128231: Use runcode() return value for failing early #129488
Uh oh!
There was an error while loading. Please reload this page.
Conversation
johnslavik commented Jan 30, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
johnslavik commented Jan 30, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Should we document the new sentinel? It seems the |
1004941 to 71c4a5fCompareEclips4 commented Jan 31, 2025
I don't think that we should document it. |
Eclips4 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you
Uh oh!
There was an error while loading. Please reload this page.
johnslavik commented Feb 12, 2025
@encukou (Pinging as discussed on stream) |
ZeroIntensity left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well throw my approval on here too. I think this makes sense.
johnslavik commented Feb 13, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Will also ping @asvetlov as he had reviewed my first PR, relevant to the (asyncio) REPL. |
encukou commented Feb 14, 2025
This makes sense to me! I'll give a chance to the REPL experts to review, but if there are no objections next week I plan to merge this. |
7ed3dc6 into python:mainUh oh!
There was an error while loading. Please reload this page.
…onGH-129488) (cherry picked from commit 7ed3dc6) Co-authored-by: Bartosz Sławecki <bartoszpiotrslawecki@gmail.com>
GH-130513 is a backport of this pull request to the 3.13 branch. |
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
ZeroIntensity commented Mar 28, 2025
Uh oh, that looks related. Should we revert the 3.13 PR @hugovk? |
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
hugovk commented Mar 28, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
The 3.13 backport is failing GHA and buildbots, it must have gotten out of sync between last CI run and merge.
Let's revert the 3.13 backport to get the CI back to green. Edit: revert PR #131834 |
bedevere-bot commented Mar 28, 2025
|
…ing early (pythonGH-129488) (python#130513)" This reverts commit 8f6a9aa.
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
bedevere-bot commented Mar 28, 2025
|
Closesgh-128231.
Any potential downstream subclasses (which are hard to imagine, but who knows, Python is big) that override
runcode()can introduce this protocol gradually, with the old behavior preserved until then (backward compatibility).