[3.13] gh-128231: Use runcode() return value for failing early (GH-129488)#130513
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…onGH-129488) (cherry picked from commit 7ed3dc6) Co-authored-by: Bartosz Sławecki <bartoszpiotrslawecki@gmail.com>
miss-islington requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners
hugovk merged commit 8f6a9aa into python:3.13 47 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Member
hugovk commented Mar 28, 2025
This 3.13 backport is failing GHA and buildbots, it must have gotten out of sync between last CI run and merge.
Let's revert this 3.13 backport to get the CI back to green. |
Member
johnslavik commented Mar 28, 2025
My intuition is that it can be simply worked-around by not printing a literal value, but e.g. |
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 28, 2025
…ing early (pythonGH-129488) (python#130513)" This reverts commit 8f6a9aa.
Member
hugovk commented Mar 28, 2025
In the meantime, I've made PR #131834 to revert. |
GH-131834 is a backport of this pull request to the 3.13 branch. |
Member
johnslavik commented Mar 28, 2025
Fixing in the original branch (#129488). |
Member
johnslavik commented Mar 28, 2025
I guess I'll need to open another PR. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7ed3dc6)
Co-authored-by: Bartosz Sławecki bartoszpiotrslawecki@gmail.com