Skip to content

Conversation

@nybblista
Copy link
Contributor

@nybblistanybblista commented Mar 13, 2025

In the "frames.md" file at InternalDocs, I have changed the first duplicated title to Specials and removed the unnecessary content under the Specials section.

In the frames.md file at InternalDocs, change the first duplicated title to Specials, and remove unnecessary content under the Specials section.
@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news awaiting review labels Mar 13, 2025
@ghost
Copy link

ghost commented Mar 13, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@@ -0,0 +1,2 @@
The duplication of titles in the frames.md file at InternalDocs has been
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a NEWS entry as it's internal documentation and not exposed documentation.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. However, it would be a good idea to add this comment as a note in the devguide, specifically in the quick reference at step 8. 👍🏻

https://devguide.python.org/#quick-reference

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean, the fact that it's an internal-only?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't hurt to specify when a NEWS entry is really needed. Thanks for the feedback!

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevnsobolevn merged commit e9d210b into python:mainMar 13, 2025
54 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsMar 13, 2025
@picnixz
Copy link
Member

I was planning to merge it after eating something but you beat me to it!

@nybblistanybblista deleted the fix-issue-131170 branch March 13, 2025 14:08
@sobolevn
Copy link
Member

In fact, I was eating while merging 🥘

plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
…1177) fix duplicated sections in frames.md file In the frames.md file at InternalDocs, change the first duplicated title to Specials, and remove unnecessary content under the Specials section.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants

@nybblista@picnixz@sobolevn@auvipy